Skip to content

Commit c73eb02

Browse files
committed
fgragh: No need to invoke the function call_filter_check_discard()
The function call_filter_check_discard() has been removed in the commit 49e4154 ("tracing: Remove TRACE_EVENT_FL_FILTERED logic"), from another topic branch. But when merged together with commit 21e9280 ("function_graph: Support recording and printing the function return address") which added another call to call_filter_check_discard(), it caused the build to fail. Since the function call_filter_check_discard() is useless, it can simply be removed regardless of being merged with commit 49e4154 or not. Link: https://lore.kernel.org/all/[email protected]/ Cc: Masami Hiramatsu <[email protected]> Cc: Mathieu Desnoyers <[email protected]> Cc: Donglin Peng <[email protected]> Link: https://lore.kernel.org/[email protected] Reported-by: Stephen Rothwell <[email protected]> Fixes: 21e9280 ("function_graph: Support recording and printing the function return address") Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent 0a6c61b commit c73eb02

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

kernel/trace/trace_functions_graph.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ int __trace_graph_retaddr_entry(struct trace_array *tr,
137137
unsigned int trace_ctx,
138138
unsigned long retaddr)
139139
{
140-
struct trace_event_call *call = &event_fgraph_retaddr_entry;
141140
struct ring_buffer_event *event;
142141
struct trace_buffer *buffer = tr->array_buffer.buffer;
143142
struct fgraph_retaddr_ent_entry *entry;
@@ -150,8 +149,7 @@ int __trace_graph_retaddr_entry(struct trace_array *tr,
150149
entry->graph_ent.func = trace->func;
151150
entry->graph_ent.depth = trace->depth;
152151
entry->graph_ent.retaddr = retaddr;
153-
if (!call_filter_check_discard(call, entry, buffer, event))
154-
trace_buffer_unlock_commit_nostack(buffer, event);
152+
trace_buffer_unlock_commit_nostack(buffer, event);
155153

156154
return 1;
157155
}

0 commit comments

Comments
 (0)