Commit c8be038
filemap: add filemap_map_order0_folio() to handle order0 folio
Kernel test robot reported regressions for several benchmarks [1].
The regression are related with commit:
de74976 ("filemap: add filemap_map_folio_range()")
It turned out that function filemap_map_folio_range() brings these
regressions when handle folio with order0.
Add filemap_map_order0_folio() to handle order0 folio. The benefit
come from two perspectives:
- the code size is smaller (around 126 bytes)
- no loop
Testing showed the regressions reported by 0day [1] all are fixed:
commit 9f1f5b6: parent commit of de74976
commit fbdf9263a3d7fdbd: latest mm-unstable commit
commit 7fbfe2003f84686d: this fixing patch
9f1f5b6 fbdf9263a3d7fdbd 7fbfe2003f84686d
---------------- --------------------------- ---------------------------
3843810 -21.4% 3020268 +4.6% 4018708 stress-ng.bad-altstack.ops
64061 -21.4% 50336 +4.6% 66977 stress-ng.bad-altstack.ops_per_sec
1709026 -14.4% 1462102 +2.4% 1750757 stress-ng.fork.ops
28483 -14.4% 24368 +2.4% 29179 stress-ng.fork.ops_per_sec
3685088 -53.6% 1710976 +0.5% 3702454 stress-ng.zombie.ops
56732 -65.3% 19667 +0.7% 57107 stress-ng.zombie.ops_per_sec
61874 -12.1% 54416 +0.4% 62136 vm-scalability.median
13527663 -11.7% 11942117 -0.1% 13513946 vm-scalability.throughput
4.066e+09 -11.7% 3.59e+09 -0.1% 4.061e+09 vm-scalability.workload
[1]:
https://lore.kernel.org/oe-lkp/[email protected]/T/#m7d2bba30f75a9cee8eab07e5809abd9b3b206c84
Link: https://lkml.kernel.org/r/[email protected]
Fixes: de74976 ("filemap: add filemap_map_folio_range()")
Signed-off-by: Yin Fengwei <[email protected]>
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-lkp/[email protected]
Cc: Feng Tang <[email protected]>
Cc: Huang Ying <[email protected]>
Cc: Matthew Wilcox (Oracle) <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>1 parent 578d769 commit c8be038
1 file changed
+48
-21
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3475 | 3475 | | |
3476 | 3476 | | |
3477 | 3477 | | |
3478 | | - | |
| 3478 | + | |
| 3479 | + | |
3479 | 3480 | | |
3480 | 3481 | | |
3481 | | - | |
3482 | | - | |
3483 | 3482 | | |
3484 | | - | |
3485 | 3483 | | |
3486 | 3484 | | |
3487 | 3485 | | |
3488 | 3486 | | |
3489 | 3487 | | |
3490 | 3488 | | |
3491 | 3489 | | |
3492 | | - | |
3493 | | - | |
| 3490 | + | |
3494 | 3491 | | |
3495 | 3492 | | |
3496 | 3493 | | |
| |||
3525 | 3522 | | |
3526 | 3523 | | |
3527 | 3524 | | |
3528 | | - | |
| 3525 | + | |
| 3526 | + | |
| 3527 | + | |
| 3528 | + | |
| 3529 | + | |
| 3530 | + | |
| 3531 | + | |
| 3532 | + | |
| 3533 | + | |
| 3534 | + | |
| 3535 | + | |
| 3536 | + | |
| 3537 | + | |
| 3538 | + | |
| 3539 | + | |
| 3540 | + | |
| 3541 | + | |
| 3542 | + | |
| 3543 | + | |
| 3544 | + | |
| 3545 | + | |
| 3546 | + | |
| 3547 | + | |
| 3548 | + | |
| 3549 | + | |
| 3550 | + | |
| 3551 | + | |
| 3552 | + | |
| 3553 | + | |
3529 | 3554 | | |
3530 | 3555 | | |
3531 | 3556 | | |
| |||
3541 | 3566 | | |
3542 | 3567 | | |
3543 | 3568 | | |
3544 | | - | |
| 3569 | + | |
3545 | 3570 | | |
3546 | 3571 | | |
3547 | 3572 | | |
| |||
3569 | 3594 | | |
3570 | 3595 | | |
3571 | 3596 | | |
3572 | | - | |
3573 | | - | |
3574 | | - | |
3575 | | - | |
3576 | | - | |
3577 | | - | |
3578 | | - | |
3579 | | - | |
3580 | | - | |
3581 | | - | |
| 3597 | + | |
| 3598 | + | |
| 3599 | + | |
| 3600 | + | |
| 3601 | + | |
| 3602 | + | |
| 3603 | + | |
3582 | 3604 | | |
3583 | | - | |
3584 | 3605 | | |
3585 | 3606 | | |
3586 | | - | |
3587 | | - | |
| 3607 | + | |
3588 | 3608 | | |
3589 | 3609 | | |
3590 | 3610 | | |
| 3611 | + | |
| 3612 | + | |
| 3613 | + | |
| 3614 | + | |
| 3615 | + | |
| 3616 | + | |
| 3617 | + | |
3591 | 3618 | | |
3592 | 3619 | | |
3593 | 3620 | | |
| |||
0 commit comments