Skip to content

Commit d7b52b4

Browse files
Al Viropaulmckrcu
authored andcommitted
sparc32: unify __cmpxchg_u{32,64}
Add a macro that expands to one of those when given u32 or u64 as an argument - atomic32.c has a lot of similar stuff already. Signed-off-by: Al Viro <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]>
1 parent b7e2a63 commit d7b52b4

File tree

1 file changed

+16
-25
lines changed

1 file changed

+16
-25
lines changed

arch/sparc/lib/atomic32.c

Lines changed: 16 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -159,32 +159,23 @@ unsigned long sp32___change_bit(unsigned long *addr, unsigned long mask)
159159
}
160160
EXPORT_SYMBOL(sp32___change_bit);
161161

162-
u32 __cmpxchg_u32(volatile u32 *ptr, u32 old, u32 new)
163-
{
164-
unsigned long flags;
165-
u32 prev;
166-
167-
spin_lock_irqsave(ATOMIC_HASH(ptr), flags);
168-
if ((prev = *ptr) == old)
169-
*ptr = new;
170-
spin_unlock_irqrestore(ATOMIC_HASH(ptr), flags);
171-
172-
return prev;
173-
}
162+
#define CMPXCHG(T) \
163+
T __cmpxchg_##T(volatile T *ptr, T old, T new) \
164+
{ \
165+
unsigned long flags; \
166+
T prev; \
167+
\
168+
spin_lock_irqsave(ATOMIC_HASH(ptr), flags); \
169+
if ((prev = *ptr) == old) \
170+
*ptr = new; \
171+
spin_unlock_irqrestore(ATOMIC_HASH(ptr), flags);\
172+
\
173+
return prev; \
174+
}
175+
176+
CMPXCHG(u32)
177+
CMPXCHG(u64)
174178
EXPORT_SYMBOL(__cmpxchg_u32);
175-
176-
u64 __cmpxchg_u64(volatile u64 *ptr, u64 old, u64 new)
177-
{
178-
unsigned long flags;
179-
u64 prev;
180-
181-
spin_lock_irqsave(ATOMIC_HASH(ptr), flags);
182-
if ((prev = *ptr) == old)
183-
*ptr = new;
184-
spin_unlock_irqrestore(ATOMIC_HASH(ptr), flags);
185-
186-
return prev;
187-
}
188179
EXPORT_SYMBOL(__cmpxchg_u64);
189180

190181
unsigned long __xchg_u32(volatile u32 *ptr, u32 new)

0 commit comments

Comments
 (0)