Skip to content

Commit d97e71e

Browse files
ch-frobertfoss
authored andcommitted
drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by default
Enable the transmission of an EoTp (end of transmission packet) by default. EoTp should be enabled anyway because it is a Linux necessity that can be disabled by a dsi mod_flag if needed. EoTp signals the end of an HS transmission, this adds overall robustness at protocol level at the expense of an increased overhead. Signed-off-by: Christoph Fritz <[email protected]> Reviewed-by: Robert Foss <[email protected]> Signed-off-by: Robert Foss <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent bb99c51 commit d97e71e

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,12 @@ static void dw_mipi_dsi_dpi_config(struct dw_mipi_dsi *dsi,
722722

723723
static void dw_mipi_dsi_packet_handler_config(struct dw_mipi_dsi *dsi)
724724
{
725-
dsi_write(dsi, DSI_PCKHDL_CFG, CRC_RX_EN | ECC_RX_EN | BTA_EN);
725+
u32 val = CRC_RX_EN | ECC_RX_EN | BTA_EN | EOTP_TX_EN;
726+
727+
if (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)
728+
val &= ~EOTP_TX_EN;
729+
730+
dsi_write(dsi, DSI_PCKHDL_CFG, val);
726731
}
727732

728733
static void dw_mipi_dsi_video_packet_config(struct dw_mipi_dsi *dsi,

0 commit comments

Comments
 (0)