bcachefs: Fix early init error path in journal code

Kent Overstreet · Kent Overstreet · commit dbf4d79b7fc7 · 2024-06-19T18:27:24.000-04:00
We shouln't be running the journal shutdown sequence if we never fully
initialized the journal.

Reported-by: syzbot+ffd2270f0bca3322ee00@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/journal.c b/fs/bcachefs/journal.c
@@ -1167,6 +1167,9 @@ void bch2_dev_journal_stop(struct journal *j, struct bch_dev *ca)
 
 void bch2_fs_journal_stop(struct journal *j)
 {
+	if (!test_bit(JOURNAL_running, &j->flags))
+		return;
+
 	bch2_journal_reclaim_stop(j);
 	bch2_journal_flush_all_pins(j);
 

Original file line number	Diff line number	Diff line change
`@@ -1167,6 +1167,9 @@ void bch2_dev_journal_stop(struct journal j, struct bch_dev ca)`
`1167`	`1167`
`1168`	`1168`	`void bch2_fs_journal_stop(struct journal *j)`
`1169`	`1169`	`{`
	`1170`	`+ if (!test_bit(JOURNAL_running, &j->flags))`
	`1171`	`+ return;`
	`1172`	`+`
`1170`	`1173`	`bch2_journal_reclaim_stop(j);`
`1171`	`1174`	`bch2_journal_flush_all_pins(j);`
`1172`	`1175`