Skip to content

Commit dce2f5b

Browse files
niedzwiecki-dawidTzung-Bi Shih
authored andcommitted
platform/chrome: cros_ec_proto: remove unnecessary retries
Remove the retry of the get protocol info command. It is not needed anymore, because RWSIG continue command is send before start of the probing. That assures the EC device is ready in RW and there is no need to try again because FPMCU is not fully booted. Signed-off-by: Dawid Niedzwiecki <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Tzung-Bi Shih <[email protected]>
1 parent 5ffa0db commit dce2f5b

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

drivers/platform/chrome/cros_ec_proto.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -366,15 +366,6 @@ static int cros_ec_get_proto_info(struct cros_ec_device *ec_dev, int devidx)
366366
msg->insize = sizeof(*info);
367367

368368
ret = cros_ec_send_command(ec_dev, msg);
369-
/*
370-
* Send command once again when timeout occurred.
371-
* Fingerprint MCU (FPMCU) is restarted during system boot which
372-
* introduces small window in which FPMCU won't respond for any
373-
* messages sent by kernel. There is no need to wait before next
374-
* attempt because we waited at least EC_MSG_DEADLINE_MS.
375-
*/
376-
if (ret == -ETIMEDOUT)
377-
ret = cros_ec_send_command(ec_dev, msg);
378369

379370
if (ret < 0) {
380371
dev_dbg(ec_dev->dev,

0 commit comments

Comments
 (0)