Skip to content

Commit ddbf320

Browse files
glneonmenon
authored andcommitted
soc: ti: wkup_m3_ipc: Send NULL dummy message instead of pointer message
mbox_send_message() sends a u32 bit message, not a pointer to a message. We only convert to a pointer type as a generic type. If we want to send a dummy message of 0, then simply send 0 (NULL). Signed-off-by: Andrew Davis <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Nishanth Menon <[email protected]>
1 parent 8c8ff39 commit ddbf320

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

drivers/soc/ti/wkup_m3_ipc.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#include <linux/irq.h>
1717
#include <linux/module.h>
1818
#include <linux/of.h>
19-
#include <linux/omap-mailbox.h>
2019
#include <linux/platform_device.h>
2120
#include <linux/remoteproc.h>
2221
#include <linux/suspend.h>
@@ -314,7 +313,6 @@ static irqreturn_t wkup_m3_txev_handler(int irq, void *ipc_data)
314313
static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc)
315314
{
316315
struct device *dev = m3_ipc->dev;
317-
mbox_msg_t dummy_msg = 0;
318316
int ret;
319317

320318
if (!m3_ipc->mbox) {
@@ -330,7 +328,7 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc)
330328
* the RX callback to avoid multiple interrupts being received
331329
* by the CM3.
332330
*/
333-
ret = mbox_send_message(m3_ipc->mbox, &dummy_msg);
331+
ret = mbox_send_message(m3_ipc->mbox, NULL);
334332
if (ret < 0) {
335333
dev_err(dev, "%s: mbox_send_message() failed: %d\n",
336334
__func__, ret);
@@ -352,7 +350,6 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc)
352350
static int wkup_m3_ping_noirq(struct wkup_m3_ipc *m3_ipc)
353351
{
354352
struct device *dev = m3_ipc->dev;
355-
mbox_msg_t dummy_msg = 0;
356353
int ret;
357354

358355
if (!m3_ipc->mbox) {
@@ -361,7 +358,7 @@ static int wkup_m3_ping_noirq(struct wkup_m3_ipc *m3_ipc)
361358
return -EIO;
362359
}
363360

364-
ret = mbox_send_message(m3_ipc->mbox, &dummy_msg);
361+
ret = mbox_send_message(m3_ipc->mbox, NULL);
365362
if (ret < 0) {
366363
dev_err(dev, "%s: mbox_send_message() failed: %d\n",
367364
__func__, ret);

0 commit comments

Comments
 (0)