Revert "driver core: fix async device shutdown hang"

This reverts commit 4f2c346.

The series is being reverted before -rc1 as there are still reports of
lockups on shutdown, so it's not quite ready for "prime time."

Reported-by: Andrey Skvortsov <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Cc: Christoph Hellwig <[email protected]>
Cc: David Jeffery <[email protected]>
Cc: Keith Busch <[email protected]>
Cc: Laurence Oberman <[email protected]>
Cc: Nathan Chancellor <[email protected]>
Cc: Sagi Grimberg <[email protected]>
Cc: Stuart Hayes <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Author: gregkh

drivers/base/core.c

@@ -4898,16 +4898,8 @@ void device_shutdown(void)
 
 		idx = device_links_read_lock();
 		list_for_each_entry_rcu(link, &dev->links.suppliers, c_node,
-				device_links_read_lock_held()) {
-			/*
-			 * sync_state_only suppliers don't need to wait,
-			 * aren't reordered on devices_kset, so making them
-			 * wait could result in a hang
-			 */
-			if (device_link_flag_is_sync_state_only(link->flags))
-				continue;
+				device_links_read_lock_held())
 			link->supplier->p->shutdown_after = cookie;
-		}
 		device_links_read_unlock(idx);
 		put_device(dev);