Skip to content

Commit e6a8156

Browse files
damien-lemoalmartinkpetersen
authored andcommitted
scsi: scsi_error: Add comments to scsi_check_sense()
Add a comment block describing the COMPLETED case with ASC/ASCQ 0x55/0xA to mention that it relates to command duration limits very special policy 0xD command completion. Signed-off-by: Damien Le Moal <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 0711f19 commit e6a8156

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/scsi/scsi_error.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -723,6 +723,13 @@ enum scsi_disposition scsi_check_sense(struct scsi_cmnd *scmd)
723723
return SUCCESS;
724724

725725
case COMPLETED:
726+
/*
727+
* A command using command duration limits (CDL) with a
728+
* descriptor set with policy 0xD may be completed with success
729+
* and the sense data DATA CURRENTLY UNAVAILABLE, indicating
730+
* that the command was in fact aborted because it exceeded its
731+
* duration limit. Never retry these commands.
732+
*/
726733
if (sshdr.asc == 0x55 && sshdr.ascq == 0x0a) {
727734
set_scsi_ml_byte(scmd, SCSIML_STAT_DL_TIMEOUT);
728735
req->cmd_flags |= REQ_FAILFAST_DEV;

0 commit comments

Comments
 (0)