Skip to content

Commit eabb038

Browse files
jdelvaregroeck
authored andcommitted
[PATCH} hwmon: (jc42) Properly detect TSE2004-compliant devices again
Commit b3e992f ("hwmon: (jc42) Strengthen detect function") attempted to make the detect function more robust for TSE2004-compliant devices by checking capability bits which, according to the JEDEC 21-C specification, should always be set. Unfortunately, not all real-world implementations fully adhere to this specification, so this change caused a regression. Stop testing bit 7 (EVSD) of the Capabilities register, as it was found to be 0 on one real-world device. Also stop testing bits 0 (EVENT) and 2 (RANGE) as vendor datasheets (Renesas TSE2004GB2B0, ST STTS2004) suggest that they may not always be set either. Signed-off-by: Jean Delvare <[email protected]> Message-ID: <[email protected]> Fixes: b3e992f ("hwmon: (jc42) Strengthen detect function") Message-ID: <[email protected]> Signed-off-by: Guenter Roeck <[email protected]>
1 parent 8e929cb commit eabb038

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hwmon/jc42.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
417417
return -ENODEV;
418418

419419
if ((devid & TSE2004_DEVID_MASK) == TSE2004_DEVID &&
420-
(cap & 0x00e7) != 0x00e7)
420+
(cap & 0x0062) != 0x0062)
421421
return -ENODEV;
422422

423423
for (i = 0; i < ARRAY_SIZE(jc42_chips); i++) {

0 commit comments

Comments
 (0)