Skip to content

Commit f58e66b

Browse files
ij-intelshuahkh
authored andcommitted
selftests/resctrl: Remove mongrp from CMT test
The CMT selftest instantiates a monitor group to read LLC occupancy. Since the test also creates a control group, it is unnecessary to create another one for monitoring because control groups already provide monitoring too. Remove the unnecessary monitor group from the CMT selftest. Suggested-by: Reinette Chatre <[email protected]> Signed-off-by: Ilpo Järvinen <[email protected]> Tested-by: Babu Moger <[email protected]> Reviewed-by: Reinette Chatre <[email protected]> Signed-off-by: Shuah Khan <[email protected]>
1 parent 64b0795 commit f58e66b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tools/testing/selftests/resctrl/cmt_test.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
#define MAX_DIFF_PERCENT 15
1818

1919
#define CON_MON_LCC_OCCUP_PATH \
20-
"%s/%s/mon_groups/%s/mon_data/mon_L3_%02d/llc_occupancy"
20+
"%s/%s/mon_data/mon_L3_%02d/llc_occupancy"
2121

2222
static int cmt_init(const struct resctrl_val_param *param, int domain_id)
2323
{
2424
sprintf(llc_occup_path, CON_MON_LCC_OCCUP_PATH, RESCTRL_PATH,
25-
param->ctrlgrp, param->mongrp, domain_id);
25+
param->ctrlgrp, domain_id);
2626

2727
return 0;
2828
}
@@ -146,7 +146,6 @@ static int cmt_run_test(const struct resctrl_test *test, const struct user_param
146146
struct resctrl_val_param param = {
147147
.resctrl_val = CMT_STR,
148148
.ctrlgrp = "c1",
149-
.mongrp = "m1",
150149
.filename = RESULT_FILE_NAME,
151150
.mask = ~(long_mask << n) & long_mask,
152151
.num_of_runs = 0,

0 commit comments

Comments
 (0)