Skip to content

Commit f892ac7

Browse files
robherringmpe
authored andcommitted
powerpc: fsl: Use of_property_read_reg() to parse "reg"
Use the recently added of_property_read_reg() helper to get the untranslated "reg" address value. Signed-off-by: Rob Herring <[email protected]> [mpe: Add required include of of_address.h] Signed-off-by: Michael Ellerman <[email protected]> Link: https://msgid.link/[email protected]
1 parent c4ae179 commit f892ac7

File tree

2 files changed

+5
-19
lines changed

2 files changed

+5
-19
lines changed

arch/powerpc/sysdev/fsl_rio.c

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -448,13 +448,11 @@ int fsl_rio_setup(struct platform_device *dev)
448448
struct rio_mport *port;
449449
struct rio_priv *priv;
450450
int rc = 0;
451-
const u32 *dt_range, *port_index;
451+
const u32 *port_index;
452452
u32 active_ports = 0;
453453
struct device_node *np, *rmu_node;
454-
int rlen;
455454
u32 ccsr;
456455
u64 range_start;
457-
int aw;
458456
u32 i;
459457
static int tmp;
460458
struct device_node *rmu_np[MAX_MSG_UNIT_NUM] = {NULL};
@@ -528,15 +526,12 @@ int fsl_rio_setup(struct platform_device *dev)
528526
dbell->bellirq = irq_of_parse_and_map(np, 1);
529527
dev_info(&dev->dev, "bellirq: %d\n", dbell->bellirq);
530528

531-
aw = of_n_addr_cells(np);
532-
dt_range = of_get_property(np, "reg", &rlen);
533-
if (!dt_range) {
529+
if (of_property_read_reg(np, 0, &range_start, NULL)) {
534530
pr_err("%pOF: unable to find 'reg' property\n",
535531
np);
536532
rc = -ENOMEM;
537533
goto err_pw;
538534
}
539-
range_start = of_read_number(dt_range, aw);
540535
dbell->dbell_regs = (struct rio_dbell_regs *)(rmu_regs_win +
541536
(u32)range_start);
542537

@@ -556,15 +551,12 @@ int fsl_rio_setup(struct platform_device *dev)
556551
pw->dev = &dev->dev;
557552
pw->pwirq = irq_of_parse_and_map(np, 0);
558553
dev_info(&dev->dev, "pwirq: %d\n", pw->pwirq);
559-
aw = of_n_addr_cells(np);
560-
dt_range = of_get_property(np, "reg", &rlen);
561-
if (!dt_range) {
554+
if (of_property_read_reg(np, 0, &range_start, NULL)) {
562555
pr_err("%pOF: unable to find 'reg' property\n",
563556
np);
564557
rc = -ENOMEM;
565558
goto err;
566559
}
567-
range_start = of_read_number(dt_range, aw);
568560
pw->pw_regs = (struct rio_pw_regs *)(rmu_regs_win + (u32)range_start);
569561

570562
/*set up ports node*/

arch/powerpc/sysdev/fsl_rmu.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <linux/types.h>
2424
#include <linux/dma-mapping.h>
2525
#include <linux/interrupt.h>
26+
#include <linux/of_address.h>
2627
#include <linux/of_irq.h>
2728
#include <linux/of_platform.h>
2829
#include <linux/slab.h>
@@ -1067,9 +1068,6 @@ int fsl_rio_setup_rmu(struct rio_mport *mport, struct device_node *node)
10671068
struct rio_priv *priv;
10681069
struct fsl_rmu *rmu;
10691070
u64 msg_start;
1070-
const u32 *msg_addr;
1071-
int mlen;
1072-
int aw;
10731071

10741072
if (!mport || !mport->priv)
10751073
return -EINVAL;
@@ -1086,16 +1084,12 @@ int fsl_rio_setup_rmu(struct rio_mport *mport, struct device_node *node)
10861084
if (!rmu)
10871085
return -ENOMEM;
10881086

1089-
aw = of_n_addr_cells(node);
1090-
msg_addr = of_get_property(node, "reg", &mlen);
1091-
if (!msg_addr) {
1087+
if (of_property_read_reg(node, 0, &msg_start, NULL)) {
10921088
pr_err("%pOF: unable to find 'reg' property of message-unit\n",
10931089
node);
10941090
kfree(rmu);
10951091
return -ENOMEM;
10961092
}
1097-
msg_start = of_read_number(msg_addr, aw);
1098-
10991093
rmu->msg_regs = (struct rio_msg_regs *)
11001094
(rmu_regs_win + (u32)msg_start);
11011095

0 commit comments

Comments
 (0)