Skip to content

Commit fc1c79b

Browse files
committed
kbuild: remove unnecessary export of RUST_LIB_SRC
If RUST_LIB_SRC is defined in the top-level Makefile (via an environment variable or command line), it is already exported. The only situation where it is defined but not exported is when the top-level Makefile is wrapped by another Makefile (e.g., GNUmakefile). I cannot think of any other use cases. I know some people use this tip to define custom variables. However, even in that case, you can export it directly in the wrapper Makefile. Example GNUmakefile: export RUST_LIB_SRC = /path/to/your/sysroot/lib/rustlib/src/rust/library include Makefile Signed-off-by: Masahiro Yamada <[email protected]> Reviewed-by: Nicolas Schier <[email protected]> Reviewed-by: Alice Ryhl <[email protected]>
1 parent cc6d281 commit fc1c79b

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -578,10 +578,6 @@ else
578578
RUSTC_OR_CLIPPY = $(RUSTC)
579579
endif
580580

581-
ifdef RUST_LIB_SRC
582-
export RUST_LIB_SRC
583-
endif
584-
585581
# Allows the usage of unstable features in stable compilers.
586582
export RUSTC_BOOTSTRAP := 1
587583

0 commit comments

Comments
 (0)