Skip to content

Commit fe85f6e

Browse files
committed
ALSA: ump: Don't clear bank selection after sending a program change
The current code clears the bank selection MSB/LSB after sending a program change, but this can be wrong, as many apps may not send the full bank selection with both MSB and LSB but sending only one. Better to keep the previous bank set. Fixes: 0b5288f ("ALSA: ump: Add legacy raw MIDI support") Cc: <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent edb3277 commit fe85f6e

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

sound/core/ump_convert.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,6 @@ static int cvt_legacy_cmd_to_ump(struct ump_cvt_to_ump *cvt,
404404
midi2->pg.bank_msb = cc->cc_bank_msb;
405405
midi2->pg.bank_lsb = cc->cc_bank_lsb;
406406
cc->bank_set = 0;
407-
cc->cc_bank_msb = cc->cc_bank_lsb = 0;
408407
}
409408
break;
410409
case UMP_MSG_STATUS_CHANNEL_PRESSURE:

0 commit comments

Comments
 (0)