Skip to content

Commit fe8637f

Browse files
bvanasschemartinkpetersen
authored andcommitted
scsi: ufs: core: Increase the START STOP UNIT timeout from one to ten seconds
One UFS vendor asked to increase the UFS timeout from 1 s to 3 s. Another UFS vendor asked to increase the UFS timeout from 1 s to 10 s. Hence this patch that increases the UFS timeout to 10 s. This patch can cause the total timeout to exceed 20 s, the Android shutdown timeout. This is fine since the loop around ufshcd_execute_start_stop() exists to deal with unit attentions and because unit attentions are reported quickly. Fixes: dcd5b76 ("scsi: ufs: Reduce the START STOP UNIT timeout") Fixes: 8f2c964 ("scsi: ufs: core: Reduce the power mode change timeout") Acked-by: Adrian Hunter <[email protected]> Reviewed-by: Stanley Chu <[email protected]> Reviewed-by: Bean Huo <[email protected]> Signed-off-by: Bart Van Assche <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin K. Petersen <[email protected]>
1 parent ac9a786 commit fe8637f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/ufs/core/ufshcd.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9184,7 +9184,8 @@ static int ufshcd_execute_start_stop(struct scsi_device *sdev,
91849184
};
91859185

91869186
return scsi_execute_cmd(sdev, cdb, REQ_OP_DRV_IN, /*buffer=*/NULL,
9187-
/*bufflen=*/0, /*timeout=*/HZ, /*retries=*/0, &args);
9187+
/*bufflen=*/0, /*timeout=*/10 * HZ, /*retries=*/0,
9188+
&args);
91889189
}
91899190

91909191
/**

0 commit comments

Comments
 (0)