Skip to content

File flags readme etc can be set indifferently with either true or false  #42

@OliverMatz

Description

@OliverMatz

The following two entry declarations in the file pom.xml are equivalent:

<entry>
     <name>/opt/foo</name>
     <file>foo</file>
     <readme>false</readme>
</entry>
<entry>
     <name>/opt/foo</name>
     <file>foo</file>
     <readme>true</readme>
</entry>

In both cases, the value entry foo will be flagged as a readme file.
The same applies to the other Boolean file flags, i.e. configuration, documentation, license, ghost, missingOk, noreplace.

This is not intuitive. As a user, I would assume that false and true are different. I think false should be equivalent to ommitting the xml-element.

I stumbled over this while reviewing the code of de.dentrassi.rpm.builder.EntryDetails.apply: It does not make any difference whether the value of, say, EntryDetails.readme is set to Boolean.TRUE or Boolean.FALSE. The corresponing file flag will be set in both cases.

I am currently fixing #41 and I am uncertain whether I should do the same there.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions