Skip to content

Commit d46f11c

Browse files
cargo fix + cargo fmt
Signed-off-by: Francesco Guardiani <[email protected]>
1 parent 8c45200 commit d46f11c

File tree

11 files changed

+69
-124
lines changed

11 files changed

+69
-124
lines changed

cloudevents-sdk-actix-web/src/server_request.rs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ use actix_web::web::{Bytes, BytesMut};
44
use actix_web::{web, HttpMessage, HttpRequest};
55
use cloudevents::event::SpecVersion;
66
use cloudevents::message::{
7-
BinaryDeserializer, BinarySerializer, Encoding, MessageAttributeValue,
8-
MessageDeserializer, StructuredDeserializer, StructuredSerializer, Result
7+
BinaryDeserializer, BinarySerializer, Encoding, MessageAttributeValue, MessageDeserializer,
8+
Result, StructuredDeserializer, StructuredSerializer,
99
};
1010
use cloudevents::{message, Event};
1111
use futures::StreamExt;
@@ -24,10 +24,7 @@ impl HttpRequestDeserializer<'_> {
2424
}
2525

2626
impl<'a> BinaryDeserializer for HttpRequestDeserializer<'a> {
27-
fn deserialize_binary<R: Sized, V: BinarySerializer<R>>(
28-
self,
29-
mut visitor: V,
30-
) -> Result<R> {
27+
fn deserialize_binary<R: Sized, V: BinarySerializer<R>>(self, mut visitor: V) -> Result<R> {
3128
if self.encoding() != Encoding::BINARY {
3229
return Err(message::Error::WrongEncoding {});
3330
}
@@ -78,10 +75,7 @@ impl<'a> BinaryDeserializer for HttpRequestDeserializer<'a> {
7875
}
7976

8077
impl<'a> StructuredDeserializer for HttpRequestDeserializer<'a> {
81-
fn deserialize_structured<R: Sized, V: StructuredSerializer<R>>(
82-
self,
83-
visitor: V,
84-
) -> Result<R> {
78+
fn deserialize_structured<R: Sized, V: StructuredSerializer<R>>(self, visitor: V) -> Result<R> {
8579
if self.encoding() != Encoding::STRUCTURED {
8680
return Err(message::Error::WrongEncoding {});
8781
}

cloudevents-sdk-actix-web/src/server_response.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ use actix_web::http::{HeaderName, HeaderValue};
44
use actix_web::HttpResponse;
55
use cloudevents::event::SpecVersion;
66
use cloudevents::message::{
7-
BinaryDeserializer, BinarySerializer, MessageAttributeValue, Result,
8-
StructuredSerializer,
7+
BinaryDeserializer, BinarySerializer, MessageAttributeValue, Result, StructuredSerializer,
98
};
109
use cloudevents::Event;
1110
use std::str::FromStr;

cloudevents-sdk-reqwest/src/client_request.rs

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
use super::headers;
22
use cloudevents::event::SpecVersion;
33
use cloudevents::message::{
4-
BinaryDeserializer, BinarySerializer, MessageAttributeValue,
5-
Result, StructuredSerializer,
4+
BinaryDeserializer, BinarySerializer, MessageAttributeValue, Result, StructuredSerializer,
65
};
76
use cloudevents::Event;
87
use reqwest::RequestBuilder;
@@ -64,10 +63,7 @@ impl StructuredSerializer<RequestBuilder> for RequestSerializer {
6463
}
6564

6665
/// Method to transform an incoming [`HttpRequest`] to [`Event`]
67-
pub fn event_to_request(
68-
event: Event,
69-
request_builder: RequestBuilder,
70-
) -> Result<RequestBuilder> {
66+
pub fn event_to_request(event: Event, request_builder: RequestBuilder) -> Result<RequestBuilder> {
7167
BinaryDeserializer::deserialize_binary(event, RequestSerializer::new(request_builder))
7268
}
7369

@@ -76,10 +72,10 @@ mod tests {
7672
use super::*;
7773
use mockito::{mock, Matcher};
7874

75+
use cloudevents::message::StructuredDeserializer;
7976
use cloudevents::EventBuilder;
8077
use serde_json::json;
8178
use url::Url;
82-
use cloudevents::message::StructuredDeserializer;
8379

8480
#[tokio::test]
8581
async fn test_request() {
@@ -164,11 +160,12 @@ mod tests {
164160
let client = reqwest::Client::new();
165161
StructuredDeserializer::deserialize_structured(
166162
input,
167-
RequestSerializer::new(client.post(&url))
168-
).unwrap()
169-
.send()
170-
.await
171-
.unwrap();
163+
RequestSerializer::new(client.post(&url)),
164+
)
165+
.unwrap()
166+
.send()
167+
.await
168+
.unwrap();
172169

173170
m.assert();
174171
}

cloudevents-sdk-reqwest/src/client_response.rs

Lines changed: 28 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
use super::headers;
2-
use reqwest::Response;
2+
use bytes::Bytes;
33
use cloudevents::event::SpecVersion;
4-
use cloudevents::message::{BinaryDeserializer, BinarySerializer, Encoding, MessageAttributeValue, MessageDeserializer, StructuredDeserializer, StructuredSerializer, Result, Error};
4+
use cloudevents::message::{
5+
BinaryDeserializer, BinarySerializer, Encoding, Error, MessageAttributeValue,
6+
MessageDeserializer, Result, StructuredDeserializer, StructuredSerializer,
7+
};
58
use cloudevents::{message, Event};
6-
use std::convert::TryFrom;
7-
use bytes::Bytes;
89
use reqwest::header::{HeaderMap, HeaderName};
10+
use reqwest::Response;
11+
use std::convert::TryFrom;
912

1013
/// Wrapper for [`Response`] that implements [`MessageDeserializer`] trait
1114
pub struct ResponseDeserializer {
@@ -20,10 +23,7 @@ impl ResponseDeserializer {
2023
}
2124

2225
impl BinaryDeserializer for ResponseDeserializer {
23-
fn deserialize_binary<R: Sized, V: BinarySerializer<R>>(
24-
self,
25-
mut visitor: V,
26-
) -> Result<R> {
26+
fn deserialize_binary<R: Sized, V: BinarySerializer<R>>(self, mut visitor: V) -> Result<R> {
2727
if self.encoding() != Encoding::BINARY {
2828
return Err(message::Error::WrongEncoding {});
2929
}
@@ -38,10 +38,10 @@ impl BinaryDeserializer for ResponseDeserializer {
3838
.get(&spec_version)
3939
.unwrap();
4040

41-
for (hn, hv) in
42-
self.headers.iter().filter(|(hn, _)| {
43-
headers::SPEC_VERSION_HEADER.ne(hn) && hn.as_str().starts_with("ce-")
44-
})
41+
for (hn, hv) in self
42+
.headers
43+
.iter()
44+
.filter(|(hn, _)| headers::SPEC_VERSION_HEADER.ne(hn) && hn.as_str().starts_with("ce-"))
4545
{
4646
let name = &hn.as_str()["ce-".len()..];
4747

@@ -74,10 +74,7 @@ impl BinaryDeserializer for ResponseDeserializer {
7474
}
7575

7676
impl StructuredDeserializer for ResponseDeserializer {
77-
fn deserialize_structured<R: Sized, V: StructuredSerializer<R>>(
78-
self,
79-
visitor: V,
80-
) -> Result<R> {
77+
fn deserialize_structured<R: Sized, V: StructuredSerializer<R>>(self, visitor: V) -> Result<R> {
8178
if self.encoding() != Encoding::STRUCTURED {
8279
return Err(message::Error::WrongEncoding {});
8380
}
@@ -92,21 +89,22 @@ impl MessageDeserializer for ResponseDeserializer {
9289
.map(|r| r.ok())
9390
.flatten()
9491
.map(|e| e.starts_with("application/cloudevents+json")),
95-
self.headers.get::<&'static HeaderName>(&headers::SPEC_VERSION_HEADER)
92+
self.headers
93+
.get::<&'static HeaderName>(&headers::SPEC_VERSION_HEADER),
9694
) {
9795
(Some(true), _) => Encoding::STRUCTURED,
9896
(_, Some(_)) => Encoding::BINARY,
99-
_ => Encoding::UNKNOWN
97+
_ => Encoding::UNKNOWN,
10098
}
10199
}
102100
}
103101

104102
/// Method to transform an incoming [`Response`] to [`Event`]
105-
pub async fn response_to_event(
106-
res: Response,
107-
) -> Result<Event> {
103+
pub async fn response_to_event(res: Response) -> Result<Event> {
108104
let h = res.headers().to_owned();
109-
let b = res.bytes().await.map_err(|e| Error::Other {source: Box::new(e)})?;
105+
let b = res.bytes().await.map_err(|e| Error::Other {
106+
source: Box::new(e),
107+
})?;
110108

111109
MessageDeserializer::into_event(ResponseDeserializer::new(h, b))
112110
}
@@ -118,8 +116,8 @@ mod tests {
118116

119117
use cloudevents::EventBuilder;
120118
use serde_json::json;
121-
use url::Url;
122119
use std::str::FromStr;
120+
use url::Url;
123121

124122
#[tokio::test]
125123
async fn test_response() {
@@ -141,10 +139,7 @@ mod tests {
141139
.build();
142140

143141
let client = reqwest::Client::new();
144-
let res = client.get(&url)
145-
.send()
146-
.await
147-
.unwrap();
142+
let res = client.get(&url).send().await.unwrap();
148143

149144
let resp = response_to_event(res).await.unwrap();
150145
assert_eq!(expected, resp);
@@ -174,12 +169,8 @@ mod tests {
174169
.extension("someint", "10")
175170
.build();
176171

177-
178172
let client = reqwest::Client::new();
179-
let res = client.get(&url)
180-
.send()
181-
.await
182-
.unwrap();
173+
let res = client.get(&url).send().await.unwrap();
183174

184175
let resp = response_to_event(res).await.unwrap();
185176
assert_eq!(expected, resp);
@@ -199,15 +190,15 @@ mod tests {
199190
let url = mockito::server_url();
200191
let _m = mock("GET", "/")
201192
.with_status(200)
202-
.with_header("content-type", "application/cloudevents+json; charset=utf-8")
193+
.with_header(
194+
"content-type",
195+
"application/cloudevents+json; charset=utf-8",
196+
)
203197
.with_body(serde_json::to_string(&expected).unwrap())
204198
.create();
205199

206200
let client = reqwest::Client::new();
207-
let res = client.get(&url)
208-
.send()
209-
.await
210-
.unwrap();
201+
let res = client.get(&url).send().await.unwrap();
211202

212203
let resp = response_to_event(res).await.unwrap();
213204
assert_eq!(expected, resp);

cloudevents-sdk-reqwest/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ mod client_response;
66
pub use client_request::event_to_request;
77
pub use client_request::RequestSerializer;
88
pub use client_response::response_to_event;
9-
pub use client_response::ResponseDeserializer;
9+
pub use client_response::ResponseDeserializer;

src/event/message.rs

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ use super::Event;
33
use super::{Attributes, AttributesReader};
44
use crate::event::SpecVersion;
55
use crate::message::{
6-
BinaryDeserializer, BinarySerializer, Result, MessageAttributeValue,
7-
StructuredDeserializer, StructuredSerializer,
6+
BinaryDeserializer, BinarySerializer, MessageAttributeValue, Result, StructuredDeserializer,
7+
StructuredSerializer,
88
};
99

1010
impl StructuredDeserializer for Event {
@@ -15,10 +15,7 @@ impl StructuredDeserializer for Event {
1515
}
1616

1717
impl BinaryDeserializer for Event {
18-
fn deserialize_binary<R: Sized, V: BinarySerializer<R>>(
19-
self,
20-
mut visitor: V,
21-
) -> Result<R> {
18+
fn deserialize_binary<R: Sized, V: BinarySerializer<R>>(self, mut visitor: V) -> Result<R> {
2219
visitor = visitor.set_spec_version(self.get_specversion())?;
2320
visitor = self.attributes.deserialize_attributes(visitor)?;
2421
for (k, v) in self.extensions.into_iter() {
@@ -37,25 +34,15 @@ impl BinaryDeserializer for Event {
3734
}
3835

3936
pub(crate) trait AttributesDeserializer {
40-
fn deserialize_attributes<R: Sized, V: BinarySerializer<R>>(
41-
self,
42-
visitor: V,
43-
) -> Result<V>;
37+
fn deserialize_attributes<R: Sized, V: BinarySerializer<R>>(self, visitor: V) -> Result<V>;
4438
}
4539

4640
pub(crate) trait AttributesSerializer {
47-
fn serialize_attribute(
48-
&mut self,
49-
name: &str,
50-
value: MessageAttributeValue,
51-
) -> Result<()>;
41+
fn serialize_attribute(&mut self, name: &str, value: MessageAttributeValue) -> Result<()>;
5242
}
5343

5444
impl AttributesDeserializer for Attributes {
55-
fn deserialize_attributes<R: Sized, V: BinarySerializer<R>>(
56-
self,
57-
visitor: V,
58-
) -> Result<V> {
45+
fn deserialize_attributes<R: Sized, V: BinarySerializer<R>>(self, visitor: V) -> Result<V> {
5946
match self {
6047
Attributes::V03(v03) => v03.deserialize_attributes(visitor),
6148
Attributes::V10(v10) => v10.deserialize_attributes(visitor),
@@ -64,11 +51,7 @@ impl AttributesDeserializer for Attributes {
6451
}
6552

6653
impl AttributesSerializer for Attributes {
67-
fn serialize_attribute(
68-
&mut self,
69-
name: &str,
70-
value: MessageAttributeValue,
71-
) -> Result<()> {
54+
fn serialize_attribute(&mut self, name: &str, value: MessageAttributeValue) -> Result<()> {
7255
match self {
7356
Attributes::V03(v03) => v03.serialize_attribute(name, value),
7457
Attributes::V10(v10) => v10.serialize_attribute(name, value),

src/event/v03/message.rs

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,8 @@
1-
use crate::message::{
2-
BinarySerializer, Result, Error, MessageAttributeValue,
3-
};
1+
use crate::message::{BinarySerializer, Error, MessageAttributeValue, Result};
42
use std::convert::TryInto;
53

64
impl crate::event::message::AttributesDeserializer for super::Attributes {
7-
fn deserialize_attributes<R: Sized, V: BinarySerializer<R>>(
8-
self,
9-
mut visitor: V,
10-
) -> Result<V> {
5+
fn deserialize_attributes<R: Sized, V: BinarySerializer<R>>(self, mut visitor: V) -> Result<V> {
116
visitor = visitor.set_attribute("id", MessageAttributeValue::String(self.id))?;
127
visitor = visitor.set_attribute("type", MessageAttributeValue::String(self.ty))?;
138
visitor = visitor.set_attribute("source", MessageAttributeValue::UriRef(self.source))?;
@@ -30,18 +25,15 @@ impl crate::event::message::AttributesDeserializer for super::Attributes {
3025
)?;
3126
}
3227
if self.time.is_some() {
33-
visitor = visitor.set_attribute("time", MessageAttributeValue::DateTime(self.time.unwrap()))?;
28+
visitor = visitor
29+
.set_attribute("time", MessageAttributeValue::DateTime(self.time.unwrap()))?;
3430
}
3531
Ok(visitor)
3632
}
3733
}
3834

3935
impl crate::event::message::AttributesSerializer for super::Attributes {
40-
fn serialize_attribute(
41-
&mut self,
42-
name: &str,
43-
value: MessageAttributeValue,
44-
) -> Result<()> {
36+
fn serialize_attribute(&mut self, name: &str, value: MessageAttributeValue) -> Result<()> {
4537
match name {
4638
"id" => self.id = value.to_string(),
4739
"type" => self.ty = value.to_string(),

src/event/v10/message.rs

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,8 @@
1-
use crate::message::{
2-
BinarySerializer, Error, MessageAttributeValue, Result,
3-
};
1+
use crate::message::{BinarySerializer, Error, MessageAttributeValue, Result};
42
use std::convert::TryInto;
53

64
impl crate::event::message::AttributesDeserializer for super::Attributes {
7-
fn deserialize_attributes<R: Sized, V: BinarySerializer<R>>(
8-
self,
9-
mut visitor: V,
10-
) -> Result<V> {
5+
fn deserialize_attributes<R: Sized, V: BinarySerializer<R>>(self, mut visitor: V) -> Result<V> {
116
visitor = visitor.set_attribute("id", MessageAttributeValue::String(self.id))?;
127
visitor = visitor.set_attribute("type", MessageAttributeValue::String(self.ty))?;
138
visitor = visitor.set_attribute("source", MessageAttributeValue::UriRef(self.source))?;
@@ -30,18 +25,15 @@ impl crate::event::message::AttributesDeserializer for super::Attributes {
3025
)?;
3126
}
3227
if self.time.is_some() {
33-
visitor = visitor.set_attribute("time", MessageAttributeValue::DateTime(self.time.unwrap()))?;
28+
visitor = visitor
29+
.set_attribute("time", MessageAttributeValue::DateTime(self.time.unwrap()))?;
3430
}
3531
Ok(visitor)
3632
}
3733
}
3834

3935
impl crate::event::message::AttributesSerializer for super::Attributes {
40-
fn serialize_attribute(
41-
&mut self,
42-
name: &str,
43-
value: MessageAttributeValue,
44-
) -> Result<()> {
36+
fn serialize_attribute(&mut self, name: &str, value: MessageAttributeValue) -> Result<()> {
4537
match name {
4638
"id" => self.id = value.to_string(),
4739
"type" => self.ty = value.to_string(),

0 commit comments

Comments
 (0)