Update Faraday version in test headers

Changed the 'User-Agent' header from Faraday v2.1.0 to v2.8.1 in multiple spec files to reflect the updated Faraday version. Also updated expected error in http_client_spec.rb from ConnectionFailed to TimeoutError for improved accuracy in test assertions.

Author: akabishau

spec/mailers/notifier_spec.rb

@@ -2,7 +2,7 @@
 require 'spec_helper'
 
 describe Notifier, type: :mailer do
-  let(:stub_request_headers) { {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Faraday v2.1.0' } }
+  let(:stub_request_headers) { {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Faraday v2.8.1' } }
   let(:study_statistics_body) {File.read('spec/support/json_data/study_statistics.json') }
   let(:mailer_stub) { stub_request(:get, 'https://classic.clinicaltrials.gov/api//info/study_statistics?fmt=json').with(headers: stub_request_headers).to_return(:status => 200, :body => study_statistics_body, :headers => {}) }
   let(:msg) { described_class.send_msg('test@gmail.com', event) }

spec/models/clinical_trials_api_v2_spec.rb

@@ -8,7 +8,7 @@
           headers: {
             'Accept'=>'*/*',
             'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-            'User-Agent'=>'Faraday v2.1.0'
+            'User-Agent'=>'Faraday v2.8.1'
           }).
         to_return(status: 200, body: '[{"nctId": "NCT123456", "title": "Sample Study"}]', headers: {})
 
@@ -27,7 +27,7 @@
           headers: {
             'Accept'=>'*/*',
             'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-            'User-Agent'=>'Faraday v2.1.0'
+            'User-Agent'=>'Faraday v2.8.1'
           }).
         to_return(status: 200, body: '{"nctId": "NCT123456", "title": "Sample Study"}', headers: {})
 
@@ -44,7 +44,7 @@
           headers: {
             'Accept'=>'*/*',
             'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-            'User-Agent'=>'Faraday v2.1.0'
+            'User-Agent'=>'Faraday v2.8.1'
           }).
         to_return(status: 200, body: '[{"field": "sampleField"}]', headers: {})
 
@@ -61,7 +61,7 @@
           headers: {
             'Accept'=>'*/*',
             'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-            'User-Agent'=>'Faraday v2.1.0'
+            'User-Agent'=>'Faraday v2.8.1'
           }).
         to_return(status: 200, body: '{"size": 100}', headers: {})
 
@@ -78,7 +78,7 @@
           headers: {
             'Accept'=>'*/*',
             'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-            'User-Agent'=>'Faraday v2.1.0'
+            'User-Agent'=>'Faraday v2.8.1'
           }).
         to_return(status: 200, body: '{"fieldValues": ["value1", "value2"]}', headers: {})
 
@@ -96,7 +96,7 @@
           headers: {
             'Accept'=>'*/*',
             'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-            'User-Agent'=>'Faraday v2.1.0'
+            'User-Agent'=>'Faraday v2.8.1'
           }).
         to_return(status: 200, body: "{\"field\": \"#{field}\", \"values\": [\"value1\", \"value2\"]}", headers: {})
 
@@ -114,7 +114,7 @@
           headers: {
             'Accept'=>'*/*',
             'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-            'User-Agent'=>'Faraday v2.1.0'
+            'User-Agent'=>'Faraday v2.8.1'
           }).
         to_return(status: 200, body: '{"listSizes": [10, 20]}', headers: {})
 
@@ -132,7 +132,7 @@
           headers: {
             'Accept'=>'*/*',
             'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
-            'User-Agent'=>'Faraday v2.1.0'
+            'User-Agent'=>'Faraday v2.8.1'
           }).
         to_return(status: 200, body: "{\"field\": \"#{field}\", \"size\": 5}", headers: {})
 

spec/models/utils/util_updater_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe Util::Updater do
-  let(:stub_request_headers) { {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Faraday v2.1.0' } }
+  let(:stub_request_headers) { {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Faraday v2.8.1' } }
   let(:ctg_api_body) {File.read('spec/support/json_data/ctg_api_all.json') }
   let(:api_url) { 'https://classic.clinicaltrials.gov/api//query/study_fields?fields=NCTId,StudyFirstPostDate,LastUpdatePostDate&fmt=json&max_rnk=1000&min_rnk=1'}
   before do

spec/services/http_client_spec.rb

@@ -99,7 +99,7 @@
 
         expect {
           api_client.get(endpoint, params)
-        }.to raise_error(Faraday::ConnectionFailed) # final error after retries
+        }.to raise_error(Faraday::TimeoutError) # final error after retries
 
         expect(WebMock).to have_requested(:get, url)
                           .with(query: params)