Skip to content

Commit 6072c48

Browse files
authored
Merge pull request #35 from cu-ecen-aeld/assignment-2-autotest-update
Updated test script to fix automatic clean and build of writer which should have been done in the finder-test.sh
2 parents 20e8857 + 07a9263 commit 6072c48

File tree

1 file changed

+28
-10
lines changed

1 file changed

+28
-10
lines changed

test/assignment2/assignment-test.sh

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,45 @@ SOURCE_DIR=$(realpath ${SCRIPTS_DIR}/../../../)
88
pushd ${SOURCE_DIR}/finder-app
99

1010
make clean
11+
if [ -x "./writer" ]; then
12+
echo "ERROR: make clean does not clean up the writer executable in ${SOURCE_DIR}/finder-app"
13+
exit 1
14+
fi
15+
1116
make
17+
if [ -x "./writer" ]; then
18+
./writer
19+
rc=$?
20+
if [ $rc -ne 1 ]; then
21+
add_validate_error "writer should have exited with return value 1 if no parameters were specified"
22+
fi
1223

13-
./writer
14-
rc=$?
15-
if [ $rc -ne 1 ]; then
16-
add_validate_error "writer should have exited with return value 1 if no parameters were specified"
24+
./writer "$filedir"
25+
rc=$?
26+
if [ $rc -ne 1 ]; then
27+
add_validate_error "writer should have exited with return value 1 if write string is not specified"
28+
fi
29+
echo "Performing make clean"
30+
make clean
31+
else
32+
echo "Makefile Error, Failed to generate writer executable in ${SOURCE_DIR}/finder-app."
33+
exit 1
1734
fi
1835

19-
./writer "$filedir"
36+
./finder-test.sh
2037
rc=$?
21-
if [ $rc -ne 1 ]; then
22-
add_validate_error "writer should have exited with return value 1 if write string is not specified"
38+
# Check if writer executable exists after finder-test.sh
39+
if [ ! -x "./writer" ]; then
40+
echo "ERROR: ./writer executable does not exist after executing finder-test.sh in ${SOURCE_DIR}/finder-app. Make sure finder-test.sh includes the necessary make step."
41+
exit 1
2342
fi
2443

25-
./finder-test.sh
26-
rc=$?
2744
if [ $rc -ne 0 ]; then
28-
add_validate_error "finder-test.sh execution failed with return code $rc"
45+
add_validate_error "finder-test.sh execution failed with return code $rc"
2946
fi
3047

3148
if [ ! -z "${validate_error}" ]; then
3249
echo "Validation failed with error list ${validate_error}"
3350
exit 1
3451
fi
52+

0 commit comments

Comments
 (0)