Added review comments to add extra checks for make and make clean

Author: Charan

test/assignment2/assignment-test.sh

@@ -8,37 +8,46 @@ SOURCE_DIR=$(realpath ${SCRIPTS_DIR}/../../../)
 pushd ${SOURCE_DIR}/finder-app
 
 make clean
-make
-
-CURRENT_DIR=$(pwd)
-EXECUTABLE="$CURRENT_DIR/writer"
+if [ -x "./writer" ]; then
+    echo "ERROR: make clean does not clean up the writer executable in ${SCRIPTS_DIR}"
+    exit 1
+fi
 
-if [ -x "$EXECUTABLE" ]; then
+make
+if [ -x "./writer" ]; then
     ./writer
-	rc=$?
-	if [ $rc -ne 1 ]; then
-		add_validate_error "writer should have exited with return value 1 if no parameters were specified"
-	fi
-
-	./writer "$filedir"
-	rc=$?
-	if [ $rc -ne 1 ]; then
-		add_validate_error "writer should have exited with return value 1 if write string is not specified"
-	fi
-	echo "Performing make clean"
+    rc=$?
+    if [ $rc -ne 1 ]; then
+        add_validate_error "writer should have exited with return value 1 if no parameters were specified"
+    fi
+
+    ./writer "$filedir"
+    rc=$?
+    if [ $rc -ne 1 ]; then
+        add_validate_error "writer should have exited with return value 1 if write string is not specified"
+    fi
+    echo "Performing make clean"
     make clean
 else
-    echo "Makefile Error, Failed to generate writer executable."
+    echo "Makefile Error, Failed to generate writer executable in ${SCRIPTS_DIR}."
     exit 1
 fi
 
 ./finder-test.sh
+
+# Check if writer executable exists after finder-test.sh
+if [ ! -x "./writer" ]; then
+    echo "ERROR: ./writer executable does not exist after executing finder-test.sh in ${SCRIPTS_DIR}. Make sure finder-test.sh includes the necessary make step."
+    exit 1
+fi
+
 rc=$?
 if [ $rc -ne 0 ]; then
-	add_validate_error "finder-test.sh execution failed with return code $rc"
+    add_validate_error "finder-test.sh execution failed with return code $rc"
 fi
 
 if [ ! -z "${validate_error}" ]; then
     echo "Validation failed with error list ${validate_error}"
     exit 1
 fi
+