Skip to content

Commit 20d3495

Browse files
committed
Revert "chore(cubestore): Add tracing for analysis and optimization pass"
This reverts commit ec41171.
1 parent ec41171 commit 20d3495

File tree

4 files changed

+0
-16
lines changed

4 files changed

+0
-16
lines changed

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

datafusion/optimizer/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ log = { workspace = true }
5252
recursive = { workspace = true, optional = true }
5353
regex = { workspace = true }
5454
regex-syntax = "0.8.0"
55-
tracing = { workspace = true }
5655

5756
[dev-dependencies]
5857
async-trait = { workspace = true }

datafusion/optimizer/src/analyzer/mod.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,6 @@ impl Analyzer {
140140
where
141141
F: FnMut(&LogicalPlan, &dyn AnalyzerRule),
142142
{
143-
let analyzer_span = tracing::trace_span!("logical_plan_analyzer");
144-
let _guard = analyzer_span.enter();
145-
146143
// verify the logical plan required invariants at the start, before analyzer
147144
plan.check_invariants(InvariantLevel::Always)
148145
.map_err(|e| e.context("Invalid input plan passed to Analyzer"))?;
@@ -168,8 +165,6 @@ impl Analyzer {
168165

169166
// TODO add common rule executor for Analyzer and Optimizer
170167
for rule in rules {
171-
let rule_span = tracing::trace_span!("analyze", name = rule.name());
172-
let _rule_span_guard = rule_span.enter();
173168
new_plan = rule
174169
.analyze(new_plan, config)
175170
.map_err(|e| e.context(rule.name()))?;

datafusion/optimizer/src/optimizer.rs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -356,9 +356,6 @@ impl Optimizer {
356356
where
357357
F: FnMut(&LogicalPlan, &dyn OptimizerRule),
358358
{
359-
let span = tracing::trace_span!("optimize");
360-
let _span_guard = span.enter();
361-
362359
// verify LP is valid, before the first LP optimizer pass.
363360
plan.check_invariants(InvariantLevel::Executable)
364361
.map_err(|e| e.context("Invalid input plan before LP Optimizers"))?;
@@ -376,13 +373,7 @@ impl Optimizer {
376373
while i < options.optimizer.max_passes {
377374
log_plan(&format!("Optimizer input (pass {i})"), &new_plan);
378375

379-
let optimizer_pass_span = tracing::trace_span!("pass", number = i);
380-
let _optimizer_pass_span_guard = optimizer_pass_span.enter();
381-
382376
for rule in &self.rules {
383-
let rule_span = tracing::trace_span!("rule", name = rule.name());
384-
let _rule_span_guard = rule_span.enter();
385-
386377
// If skipping failed rules, copy plan before attempting to rewrite
387378
// as rewriting is destructive
388379
let prev_plan = options

0 commit comments

Comments
 (0)