fix(cube): Remove mistaken ILike to string equality optimization

srh · srh · commit 8095609cf264 · 2025-04-21T16:38:41.000-07:00
diff --git a/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs b/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
@@ -1512,7 +1512,7 @@ impl<S: SimplifyInfo> TreeNodeRewriter for Simplifier<'_, S> {
                                 }))
                             }
                             Some(pattern_str)
-                                if !pattern_str
+                                if !like.case_insensitive && !pattern_str
                                     .contains(['%', '_', escape_char].as_ref()) =>
                             {
                                 // If the pattern does not contain any wildcards, we can simplify the like expression to an equality expression

Original file line number	Diff line number	Diff line change
`@@ -1512,7 +1512,7 @@ impl<S: SimplifyInfo> TreeNodeRewriter for Simplifier<'_, S> {`
`1512`	`1512`	`}))`
`1513`	`1513`	`}`
`1514`	`1514`	`Some(pattern_str)`
`1515`		`- if !pattern_str`
	`1515`	`+ if !like.case_insensitive && !pattern_str`
`1516`	`1516`	`.contains(['%', '_', escape_char].as_ref()) =>`
`1517`	`1517`	`{`
`1518`	`1518`	`// If the pattern does not contain any wildcards, we can simplify the like expression to an equality expression`