test(cube): Fix test failures broken by string->boolean coercion change

Author: srh

datafusion/optimizer/src/analyzer/type_coercion.rs

@@ -1632,11 +1632,15 @@ mod test {
         let expected = "Projection: a IS UNKNOWN\n  EmptyRelation";
         assert_analyzed_plan_eq(Arc::new(TypeCoercion::new()), plan, expected)?;
 
-        let empty = empty_with_type(Utf8);
+        // Cube: Using Binary instead of Utf8, because string->boolean coercion has been added.
+        // let empty = empty_with_type(Utf8);
+        let empty = empty_with_type(DataType::Binary);
         let plan = LogicalPlan::Projection(Projection::try_new(vec![expr], empty)?);
         let ret = assert_analyzed_plan_eq(Arc::new(TypeCoercion::new()), plan, expected);
         let err = ret.unwrap_err().to_string();
-        assert!(err.contains("Cannot infer common argument type for comparison operation Utf8 IS DISTINCT FROM Boolean"), "{err}");
+        // Cube:
+        // assert!(err.contains("Cannot infer common argument type for comparison operation Utf8 IS DISTINCT FROM Boolean"), "{err}");
+        assert!(err.contains("Cannot infer common argument type for comparison operation Binary IS DISTINCT FROM Boolean"), "{err}");
 
         // is not unknown
         let expr = col("a").is_not_unknown();

datafusion/sqllogictest/test_files/scalar.slt

@@ -1548,7 +1548,9 @@ SELECT null, not(null)
 ----
 NULL NULL
 
-query error type_coercion\ncaused by\nError during planning: Cannot infer common argument type for comparison operation Utf8 IS DISTINCT FROM Boolean
+# Cube: We added string->bool conversion
+# query error type_coercion\ncaused by\nError during planning: Cannot infer common argument type for comparison operation Utf8 IS DISTINCT FROM Boolean
+query error DataFusion error: Arrow error: Cast error: Cannot cast value 'hi' to value of Boolean type
 SELECT NOT('hi')
 
 # test_negative_expressions()

datafusion/sqllogictest/test_files/type_coercion.slt

@@ -239,8 +239,9 @@ logical_plan
 11)----------EmptyRelation
 
 # union_with_incompatible_data_types()
-query error Incompatible inputs for Union: Previous inputs were of type Utf8, but got incompatible type Boolean on column 'a'
-SELECT 'a' a UNION ALL SELECT true a
+# Cube: Changed this test to avoid string->boolean coercion that was added
+query error Incompatible inputs for Union: Previous inputs were of type Binary, but got incompatible type Boolean on column 'a'
+SELECT CAST('a' AS BYTEA) a UNION ALL SELECT true a
 
 statement ok
 SET datafusion.optimizer.max_passes = 3;