test(cube): Fix test failures broken by number->boolean coercion change

Author: srh

datafusion/expr-common/src/type_coercion/binary.rs

@@ -1607,7 +1607,16 @@ mod tests {
         let result_type =
             BinaryTypeCoercer::new(&input_decimal, &Operator::Eq, &DataType::Boolean)
                 .get_input_types();
+        // Cube: Actually we pass this one with number->bool conversion
+        // assert!(result_type.is_err());
+        assert!(result_type.is_ok());
+
+        // Cube: Here's a failing one
+        let result_type =
+            BinaryTypeCoercer::new(&input_decimal, &Operator::Eq, &DataType::Binary)
+                .get_input_types();
         assert!(result_type.is_err());
+
         Ok(())
     }
 

datafusion/physical-expr/src/expressions/case.rs

@@ -1077,7 +1077,9 @@ mod tests {
             None,
             schema.as_ref(),
         );
-        assert!(expr.is_err());
+        // Cube: expr is not err because of number to boolean conversion
+        // assert!(expr.is_err());
+        assert!(!expr.is_err());
 
         // then 1 is int32
         // then 2 is int64

datafusion/sqllogictest/test_files/scalar.slt

@@ -1536,8 +1536,12 @@ SELECT not(true), not(false)
 ----
 false true
 
-query error type_coercion\ncaused by\nError during planning: Cannot infer common argument type for comparison operation Int64 IS DISTINCT FROM Boolean
+# Cube: We added number->bool conversion
+# query error type_coercion\ncaused by\nError during planning: Cannot infer common argument type for comparison operation Int64 IS DISTINCT FROM Boolean
+query BB
 SELECT not(1), not(0)
+----
+false true
 
 query ?B
 SELECT null, not(null)