Skip to content

Conversation

@MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Aug 27, 2025

This PR fixes an issue with queries like this:

SELECT table_name
FROM information_schema.tables
WHERE table_name IN (
  SELECT table_name
  FROM information_schema.tables
  WHERE tables.table_name = 'tables'
)

In this case, the inner WHERE clause would pick outer table_name column due to a logic error in compound identifier planning.

Related test is included, plus incorrect tests are adjusted.

Additionally, this PR fixes CI tests by ignoring a test that requires parquet compression, a feature that was recently disabled in this fork, and by disabling a lint with archery that does not work.

@MazterQyou MazterQyou force-pushed the cubesql/subquery-prioritize-inner-field branch 6 times, most recently from f17ecef to cd6532b Compare August 27, 2025 15:15
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

Please add a small note on why CI and test are commented out/ignored.

@MazterQyou MazterQyou force-pushed the cubesql/subquery-prioritize-inner-field branch from cd6532b to 96d574f Compare August 27, 2025 15:40
@MazterQyou MazterQyou merged commit 0ba29ac into cubesql-3-04-2022 Aug 27, 2025
19 of 21 checks passed
@MazterQyou MazterQyou deleted the cubesql/subquery-prioritize-inner-field branch August 27, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants