Remove dependency on nightly compiler in DataFusion

To unbreak CI builds.

Author: ilya-biryukov

rust/arrow/src/compute/kernels/sort.rs

@@ -111,7 +111,7 @@ where
 // implements comparison using IEEE 754 total ordering for f32
 // Original implementation from https://doc.rust-lang.org/std/primitive.f64.html#method.total_cmp
 // TODO to change to use std when it becomes stable
-pub(crate) fn total_cmp_32(l: f32, r: f32) -> std::cmp::Ordering {
+pub fn total_cmp_32(l: f32, r: f32) -> std::cmp::Ordering {
     let mut left = l.to_bits() as i32;
     let mut right = r.to_bits() as i32;
 
@@ -124,7 +124,7 @@ pub(crate) fn total_cmp_32(l: f32, r: f32) -> std::cmp::Ordering {
 // implements comparison using IEEE 754 total ordering for f64
 // Original implementation from https://doc.rust-lang.org/std/primitive.f64.html#method.total_cmp
 // TODO to change to use std when it becomes stable
-pub(crate) fn total_cmp_64(l: f64, r: f64) -> std::cmp::Ordering {
+pub fn total_cmp_64(l: f64, r: f64) -> std::cmp::Ordering {
     let mut left = l.to_bits() as i64;
     let mut right = r.to_bits() as i64;
 

rust/datafusion/src/cube_ext/util.rs

@@ -17,6 +17,7 @@
 
 use crate::scalar::ScalarValue;
 use arrow::array::ArrayRef;
+use arrow::compute::{total_cmp_32, total_cmp_64};
 use std::cmp::Ordering;
 
 /// Generic code to help implement generic operations on arrays.
@@ -195,8 +196,12 @@ pub fn cmp_same_types(
 
     let o = match (l, r) {
         (ScalarValue::Boolean(Some(l)), ScalarValue::Boolean(Some(r))) => l.cmp(r),
-        (ScalarValue::Float32(Some(l)), ScalarValue::Float32(Some(r))) => l.total_cmp(r),
-        (ScalarValue::Float64(Some(l)), ScalarValue::Float64(Some(r))) => l.total_cmp(r),
+        (ScalarValue::Float32(Some(l)), ScalarValue::Float32(Some(r))) => {
+            total_cmp_32(*l, *r)
+        }
+        (ScalarValue::Float64(Some(l)), ScalarValue::Float64(Some(r))) => {
+            total_cmp_64(*l, *r)
+        }
         (ScalarValue::Int8(Some(l)), ScalarValue::Int8(Some(r))) => l.cmp(r),
         (ScalarValue::Int16(Some(l)), ScalarValue::Int16(Some(r))) => l.cmp(r),
         (ScalarValue::Int32(Some(l)), ScalarValue::Int32(Some(r))) => l.cmp(r),
@@ -283,12 +288,12 @@ pub fn cmp_array_row_same_types(
         ($l: expr, Float32Array, $($rest: tt)*) => {{
             let l = $l.as_any().downcast_ref::<Float32Array>().unwrap();
             let r = r.as_any().downcast_ref::<Float32Array>().unwrap();
-            return l.value(l_row).total_cmp(&r.value(r_row));
+            return arrow::compute::total_cmp_32(l.value(l_row), r.value(r_row));
         }};
         ($l: expr, Float64Array, $($rest: tt)*) => {{
             let l = $l.as_any().downcast_ref::<Float64Array>().unwrap();
             let r = r.as_any().downcast_ref::<Float64Array>().unwrap();
-            return l.value(l_row).total_cmp(&r.value(r_row));
+            return arrow::compute::total_cmp_64(l.value(l_row), r.value(r_row));
         }};
         ($l: expr, $arr: ty, $($rest: tt)*) => {{
             let l = $l.as_any().downcast_ref::<$arr>().unwrap();

rust/datafusion/src/lib.rs

@@ -1,4 +1,3 @@
-#![feature(total_cmp)]
 // Licensed to the Apache Software Foundation (ASF) under one
 // or more contributor license agreements.  See the NOTICE file
 // distributed with this work for additional information