Fix default arrow build (apache#533)

* Remove workaround for rand

* Fix for default features

Author: alamb

arrow-pyarrow-integration-testing/Cargo.toml

@@ -31,8 +31,6 @@ name = "arrow_pyarrow_integration_testing"
 crate-type = ["cdylib"]
 
 [dependencies]
-# ensure we get the std version of rand so arrow builds without default features
-rand = { version = "0.8" }
 arrow = { path = "../arrow", version = "5.0.0-SNAPSHOT" }
 pyo3 = { version = "0.12.1", features = ["extension-module"] }
 

arrow/Cargo.toml

@@ -58,12 +58,15 @@ multiversion = "0.6.1"
 bitflags = "1.2.1"
 
 [features]
-default = ["csv", "ipc"]
+default = ["csv", "ipc", "test_utils"]
 avx512 = []
 csv = ["csv_crate"]
 ipc = ["flatbuffers"]
 simd = ["packed_simd"]
 prettyprint = ["prettytable-rs"]
+# The test utils feature enables code used in benchmarks and tests but
+# not the core arrow code itself
+test_utils = ["rand/std", "rand/std_rng"]
 # this is only intended to be used in single-threaded programs: it verifies that
 # all allocated memory is being released (no memory leaks).
 # See README for details

arrow/src/util/bit_util.rs

@@ -125,7 +125,7 @@ where
     simd_result.write_to_slice_unaligned_unchecked(result);
 }
 
-#[cfg(test)]
+#[cfg(all(test, feature = "test_utils"))]
 mod tests {
     use std::collections::HashSet;
 

arrow/src/util/mod.rs

@@ -15,16 +15,20 @@
 // specific language governing permissions and limitations
 // under the License.
 
+#[cfg(feature = "test_utils")]
 pub mod bench_util;
 pub mod bit_chunk_iterator;
 pub mod bit_util;
+#[cfg(feature = "test_utils")]
 pub mod data_gen;
 pub mod display;
+#[cfg(feature = "test_utils")]
 pub mod integration_util;
 #[cfg(feature = "prettyprint")]
 pub mod pretty;
 pub(crate) mod serialization;
 pub mod string_writer;
+#[cfg(feature = "test_utils")]
 pub mod test_util;
 
 mod trusted_len;

arrow/test/dependency/default-features/Cargo.toml

@@ -26,7 +26,4 @@ edition = "2018"
 [dependencies]
 arrow = { path = "../../../../arrow", version = "5.0.0-SNAPSHOT" }
 
-# Workaround for https://github.com/apache/arrow-rs/issues/529
-rand = { version = "0.8" }
-
 [workspace]

arrow/test/dependency/no-default-features/Cargo.toml

@@ -26,7 +26,4 @@ edition = "2018"
 [dependencies]
 arrow = { path = "../../../../arrow", version = "5.0.0-SNAPSHOT", default-features = false }
 
-# Workaround for https://github.com/apache/arrow-rs/issues/529
-rand = { version = "0.8" }
-
 [workspace]