Skip to content

Commit 232ee9c

Browse files
committed
fix(ItemBase): description padding
1 parent e8b7e14 commit 232ee9c

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

src/components/content/ItemBase/ItemBase.stories.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -974,6 +974,7 @@ export const WithDescriptionBlock: StoryFn<CubeItemBaseProps> = (args) => (
974974
<ItemBase
975975
{...args}
976976
styles={DEFAULT_STYLES}
977+
type="outline"
977978
icon={<IconUser />}
978979
description="This description appears inside the content area"
979980
descriptionPlacement="inline"
@@ -983,6 +984,7 @@ export const WithDescriptionBlock: StoryFn<CubeItemBaseProps> = (args) => (
983984
<ItemBase
984985
{...args}
985986
styles={DEFAULT_STYLES}
987+
type="outline"
986988
icon={<IconUser />}
987989
description="This description appears below the entire item"
988990
descriptionPlacement="block"
@@ -996,6 +998,7 @@ export const WithDescriptionBlock: StoryFn<CubeItemBaseProps> = (args) => (
996998
<ItemBase
997999
{...args}
9981000
styles={DEFAULT_STYLES}
1001+
type="outline"
9991002
size="small"
10001003
icon={<IconSettings />}
10011004
description="Small size description block"
@@ -1006,6 +1009,7 @@ export const WithDescriptionBlock: StoryFn<CubeItemBaseProps> = (args) => (
10061009
<ItemBase
10071010
{...args}
10081011
styles={DEFAULT_STYLES}
1012+
type="outline"
10091013
size="medium"
10101014
icon={<IconSettings />}
10111015
description="Medium size description block"
@@ -1016,6 +1020,7 @@ export const WithDescriptionBlock: StoryFn<CubeItemBaseProps> = (args) => (
10161020
<ItemBase
10171021
{...args}
10181022
styles={DEFAULT_STYLES}
1023+
type="outline"
10191024
size="large"
10201025
icon={<IconSettings />}
10211026
description="Large size description block"
@@ -1030,6 +1035,7 @@ export const WithDescriptionBlock: StoryFn<CubeItemBaseProps> = (args) => (
10301035
<ItemBase
10311036
{...args}
10321037
styles={DEFAULT_STYLES}
1038+
type="outline"
10331039
icon={<IconCoin />}
10341040
rightIcon={<IconSettings />}
10351041
prefix="$"
@@ -1042,6 +1048,7 @@ export const WithDescriptionBlock: StoryFn<CubeItemBaseProps> = (args) => (
10421048
<ItemBase
10431049
{...args}
10441050
styles={DEFAULT_STYLES}
1051+
type="outline"
10451052
icon={<IconUser />}
10461053
hotkeys="cmd+u"
10471054
description="User management with hotkey and description block"
@@ -1055,6 +1062,7 @@ export const WithDescriptionBlock: StoryFn<CubeItemBaseProps> = (args) => (
10551062
<ItemBase
10561063
{...args}
10571064
styles={{ ...DEFAULT_STYLES, width: '350px' }}
1065+
type="outline"
10581066
icon={<IconCoin />}
10591067
description="This is a very long description that demonstrates how the description text flows when positioned below the item. It can contain multiple lines and will wrap naturally."
10601068
descriptionPlacement="block"

src/components/content/ItemBase/ItemBase.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -332,14 +332,17 @@ const ItemBaseElement = tasty({
332332
'(with-icon | with-prefix) & (with-right-icon | with-suffix)':
333333
'0 0 $block-padding 0',
334334
'with-description-block':
335-
'0 ($inline-padding - $inline-compensation + 1bw) $block-padding ($inline-padding - $inline-compensation + 1bw)',
335+
'0 ($inline-padding - $inline-compensation + 1bw) $bottom-padding ($inline-padding - $inline-compensation + 1bw)',
336336
'with-description-block & !with-icon':
337-
'0 ($inline-padding - $inline-compensation + 1bw) $block-padding $inline-padding',
337+
'0 ($inline-padding - $inline-compensation + 1bw) $bottom-padding $inline-padding',
338338
'with-description-block & !with-right-icon':
339-
'0 $inline-padding $block-padding ($inline-padding - $inline-compensation + 1bw)',
339+
'0 $inline-padding $bottom-padding ($inline-padding - $inline-compensation + 1bw)',
340340
'with-description-block & !with-right-icon & !with-icon':
341-
'0 $inline-padding $block-padding $inline-padding',
341+
'0 $inline-padding $bottom-padding $inline-padding',
342342
},
343+
344+
'$bottom-padding':
345+
'max($block-padding, (($size - 4x) / 2) + $block-padding)',
343346
},
344347

345348
Prefix: {

0 commit comments

Comments
 (0)