Skip to content

Commit 50cf8a7

Browse files
authored
fix(ComboBox): qa prop (#832)
1 parent 9995e8a commit 50cf8a7

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

.changeset/great-eggs-tell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@cube-dev/ui-kit": patch
3+
---
4+
5+
Fix qa prop binding in ComboBox.

src/components/fields/ComboBox/ComboBox.tsx

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ type FilterFn = (textValue: string, inputValue: string) => boolean;
6262
export type PopoverTriggerAction = 'focus' | 'input' | 'manual';
6363

6464
const ComboBoxWrapperElement = tasty({
65+
qa: 'ComboBoxWrapper',
6566
styles: INPUT_WRAPPER_STYLES,
6667
});
6768

@@ -699,6 +700,7 @@ function useComboBoxKeyboard({
699700
// Component: ComboBoxInput
700701
// ============================================================================
701702
interface ComboBoxInputProps {
703+
qa?: string;
702704
inputRef: RefObject<HTMLInputElement>;
703705
id?: string;
704706
value: string;
@@ -717,13 +719,12 @@ interface ComboBoxInputProps {
717719
hasResults: boolean;
718720
comboBoxId: string;
719721
listStateRef: RefObject<any>;
720-
isLoading?: boolean;
721-
allowsCustomValue?: boolean;
722722
}
723723

724724
const ComboBoxInput = forwardRef<HTMLInputElement, ComboBoxInputProps>(
725725
function ComboBoxInput(
726726
{
727+
qa,
727728
inputRef,
728729
id,
729730
value,
@@ -742,8 +743,6 @@ const ComboBoxInput = forwardRef<HTMLInputElement, ComboBoxInputProps>(
742743
hasResults,
743744
comboBoxId,
744745
listStateRef,
745-
isLoading,
746-
allowsCustomValue,
747746
},
748747
ref,
749748
) {
@@ -752,7 +751,7 @@ const ComboBoxInput = forwardRef<HTMLInputElement, ComboBoxInputProps>(
752751
return (
753752
<InputElement
754753
ref={combinedRef}
755-
qa="Input"
754+
qa={qa}
756755
id={id}
757756
type="text"
758757
value={value}
@@ -1569,7 +1568,6 @@ export const ComboBox = forwardRef(function ComboBox<T extends object>(
15691568
const comboBoxField = (
15701569
<ComboBoxWrapperElement
15711570
ref={wrapperRef}
1572-
qa={qa || 'ComboBox'}
15731571
mods={mods}
15741572
styles={styles}
15751573
style={{
@@ -1580,6 +1578,7 @@ export const ComboBox = forwardRef(function ComboBox<T extends object>(
15801578
>
15811579
{prefix ? <div data-element="Prefix">{prefix}</div> : null}
15821580
<ComboBoxInput
1581+
qa={qa || 'ComboBox'}
15831582
inputRef={inputRef}
15841583
id={id}
15851584
value={effectiveInputValue}
@@ -1596,8 +1595,6 @@ export const ComboBox = forwardRef(function ComboBox<T extends object>(
15961595
hasResults={hasResults}
15971596
comboBoxId={comboBoxId}
15981597
listStateRef={listStateRef}
1599-
isLoading={isLoading}
1600-
allowsCustomValue={allowsCustomValue}
16011598
onChange={handleInputChange}
16021599
onFocus={handleInputFocus}
16031600
/>

0 commit comments

Comments
 (0)