Skip to content

Commit 91a6cf9

Browse files
committed
fix(Button): styles
1 parent c155098 commit 91a6cf9

File tree

2 files changed

+27
-17
lines changed

2 files changed

+27
-17
lines changed

src/components/actions/Button/Button.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,9 @@ const ButtonElement = tasty({
110110
'[data-type="secondary"]': '#purple.15',
111111
'[data-type="secondary"] & pressed': '#purple.3',
112112
'[data-type="clear"]': '#clear',
113-
'[data-type="outline"]': '#border',
114113
'[data-type="clear"] & pressed': '#purple-text.10',
115-
'[data-type="outline"] | [disabled]': '#dark.12',
116-
'[data-type="neutral"]': '#clear',
114+
'[data-type="outline"]': '#dark.12',
115+
'[data-type="neutral"] | [disabled]': '#clear',
117116
focused: '#purple-text',
118117
'[data-type="link"]': '0',
119118
},
@@ -169,7 +168,7 @@ const ButtonElement = tasty({
169168
'[data-type="clear"]': '#clear',
170169
'[data-type="outline"]': '#danger.15',
171170
'[data-type="outline"] & pressed': '#danger.3',
172-
'[data-type="neutral"]': '#clear',
171+
'[data-type="neutral"] | [disabled]': '#clear',
173172
focused: '#danger-text',
174173
'[data-type="link"]': '#clear',
175174
},
@@ -224,7 +223,7 @@ const ButtonElement = tasty({
224223
'[data-type="clear"]': '#clear',
225224
'[data-type="outline"]': '#success.15',
226225
'[data-type="outline"] & pressed': '#success.3',
227-
'[data-type="neutral"]': '#clear',
226+
'[data-type="neutral"] | [disabled]': '#clear',
228227
focused: '#success-text',
229228
'[data-type="link"]': '#clear',
230229
},
@@ -279,6 +278,7 @@ const ButtonElement = tasty({
279278
'([data-type="outline"] | [data-type="neutral"]) & !pressed':
280279
'#white.3',
281280
'![data-type="primary"] & focused': '#white',
281+
'[disabled]': '#white.3',
282282
'[data-type="link"]': false,
283283
},
284284
fill: {

src/icons/Icon.tsx

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
1-
import { ForwardedRef, forwardRef, memo } from 'react';
1+
import {
2+
cloneElement,
3+
ForwardedRef,
4+
forwardRef,
5+
memo,
6+
ReactElement,
7+
} from 'react';
28

39
import {
410
BASE_STYLES,
@@ -11,7 +17,6 @@ import {
1117
Styles,
1218
tasty,
1319
} from '../tasty';
14-
import { mergeProps } from '../utils/react/index';
1520

1621
const IconElement = tasty({
1722
as: 'span',
@@ -43,6 +48,7 @@ export interface CubeIconProps
4348
BaseStyleProps {
4449
size?: Styles['fontSize'];
4550
stroke?: number;
51+
children: ReactElement;
4652
}
4753

4854
export const Icon = memo(
@@ -52,16 +58,20 @@ export const Icon = memo(
5258
) {
5359
const { size, stroke, ...rest } = props;
5460

55-
const mergedProps =
56-
size != null || stroke != null
57-
? mergeProps(rest, {
58-
styles: {
59-
...(size ? { fontSize: size } : {}),
60-
...(stroke ? { '@stroke-width': stroke } : {}),
61-
},
62-
})
63-
: rest;
61+
const icon = cloneElement(rest.children, {
62+
size: typeof size === 'number' ? size : undefined,
63+
stroke,
64+
});
6465

65-
return <IconElement ref={ref} qa="Icon" {...mergedProps} />;
66+
return (
67+
<IconElement
68+
ref={ref}
69+
qa="Icon"
70+
{...rest}
71+
styles={{ fontSize: size, ...rest.styles }}
72+
>
73+
{icon}
74+
</IconElement>
75+
);
6676
}),
6777
);

0 commit comments

Comments
 (0)