Skip to content

Commit 982b9ee

Browse files
committed
fix: evaluate FilterPicker renderSummary regardless of selection state
1 parent 296c804 commit 982b9ee

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@cube-dev/ui-kit": patch
3+
---
4+
5+
Fix FilterPicker `renderSummary` to be evaluated regardless of selection state. The custom summary renderer and `renderSummary={false}` now work correctly even when no items are selected, providing consistent control over trigger content display.
6+

src/components/fields/FilterPicker/FilterPicker.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ export const FilterPicker = forwardRef(function FilterPicker<T extends object>(
586586

587587
const renderTriggerContent = () => {
588588
// When there is a selection and a custom summary renderer is provided – use it.
589-
if (hasSelection && typeof renderSummary === 'function') {
589+
if (typeof renderSummary === 'function') {
590590
if (selectionMode === 'single') {
591591
return renderSummary({
592592
selectedLabel: selectedLabels[0],
@@ -602,7 +602,7 @@ export const FilterPicker = forwardRef(function FilterPicker<T extends object>(
602602
selectedKeys: effectiveSelectedKeys,
603603
selectionMode: 'multiple',
604604
});
605-
} else if (hasSelection && renderSummary === false) {
605+
} else if (renderSummary === false) {
606606
return null;
607607
}
608608

0 commit comments

Comments
 (0)