Skip to content

Commit a7473b8

Browse files
committed
fix(Menu): fix unresponsive item on tap to click * 8
1 parent 3b4c0e5 commit a7473b8

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/components/pickers/Menu/Menu.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ function Menu<T extends object>(
9494
itemStyles={itemStyles}
9595
headingStyles={sectionHeadingStyles}
9696
selectionIcon={selectionIcon}
97-
onAction={completeProps.onAction}
9897
/>
9998
);
10099
}
@@ -106,7 +105,7 @@ function Menu<T extends object>(
106105
state={state}
107106
styles={itemStyles}
108107
selectionIcon={selectionIcon}
109-
onAction={completeProps.onAction}
108+
onAction={item.onAction}
110109
/>
111110
);
112111

src/components/pickers/Menu/MenuButton.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ export type MenuButtonProps = {
101101
isSelectable?: boolean;
102102
isSelected?: boolean;
103103
icon?: ReactElement;
104+
onAction?: () => void;
104105
} & CubeBlockProps;
105106

106107
const getSelectionTypeIcon = (selectionIcon?: MenuSelectionType) => {

src/components/pickers/Menu/MenuSection.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export interface CubeMenuSectionProps<T> extends MenuItemProps<T> {
1616

1717
/** @private */
1818
export function MenuSection<T>(props: CubeMenuSectionProps<T>) {
19-
const { item, state, styles, itemStyles, headingStyles, onAction } = props;
19+
const { item, state, styles, itemStyles, headingStyles } = props;
2020
const heading = item.rendered;
2121
const { itemProps, headingProps, groupProps } = useMenuSection({
2222
heading,
@@ -39,7 +39,8 @@ export function MenuSection<T>(props: CubeMenuSectionProps<T>) {
3939
item={node}
4040
styles={itemStyles}
4141
state={state}
42-
onAction={onAction}
42+
// @ts-ignore
43+
onAction={node.onAction}
4344
/>
4445
);
4546

0 commit comments

Comments
 (0)