Skip to content

Commit db4bf34

Browse files
committed
fix(ComboBox): qa prop
1 parent 8870d82 commit db4bf34

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

.changeset/great-eggs-tell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@cube-dev/ui-kit": patch
3+
---
4+
5+
Fix qa prop binding in ComboBox.

src/components/fields/ComboBox/ComboBox.tsx

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ type FilterFn = (textValue: string, inputValue: string) => boolean;
6262
export type PopoverTriggerAction = 'focus' | 'input' | 'manual';
6363

6464
const ComboBoxWrapperElement = tasty({
65+
qa: 'ComboBoxWrapper',
6566
styles: INPUT_WRAPPER_STYLES,
6667
});
6768

@@ -695,6 +696,7 @@ function useComboBoxKeyboard({
695696
// Component: ComboBoxInput
696697
// ============================================================================
697698
interface ComboBoxInputProps {
699+
qa?: string;
698700
inputRef: RefObject<HTMLInputElement>;
699701
id?: string;
700702
value: string;
@@ -713,13 +715,12 @@ interface ComboBoxInputProps {
713715
hasResults: boolean;
714716
comboBoxId: string;
715717
listStateRef: RefObject<any>;
716-
isLoading?: boolean;
717-
allowsCustomValue?: boolean;
718718
}
719719

720720
const ComboBoxInput = forwardRef<HTMLInputElement, ComboBoxInputProps>(
721721
function ComboBoxInput(
722722
{
723+
qa,
723724
inputRef,
724725
id,
725726
value,
@@ -738,8 +739,6 @@ const ComboBoxInput = forwardRef<HTMLInputElement, ComboBoxInputProps>(
738739
hasResults,
739740
comboBoxId,
740741
listStateRef,
741-
isLoading,
742-
allowsCustomValue,
743742
},
744743
ref,
745744
) {
@@ -748,7 +747,6 @@ const ComboBoxInput = forwardRef<HTMLInputElement, ComboBoxInputProps>(
748747
return (
749748
<InputElement
750749
ref={combinedRef}
751-
qa="Input"
752750
id={id}
753751
type="text"
754752
value={value}
@@ -1565,7 +1563,6 @@ export const ComboBox = forwardRef(function ComboBox<T extends object>(
15651563
const comboBoxField = (
15661564
<ComboBoxWrapperElement
15671565
ref={wrapperRef}
1568-
qa={qa || 'ComboBox'}
15691566
mods={mods}
15701567
styles={styles}
15711568
style={{
@@ -1576,6 +1573,7 @@ export const ComboBox = forwardRef(function ComboBox<T extends object>(
15761573
>
15771574
{prefix ? <div data-element="Prefix">{prefix}</div> : null}
15781575
<ComboBoxInput
1576+
qa={qa}
15791577
inputRef={inputRef}
15801578
id={id}
15811579
value={effectiveInputValue}
@@ -1592,8 +1590,6 @@ export const ComboBox = forwardRef(function ComboBox<T extends object>(
15921590
hasResults={hasResults}
15931591
comboBoxId={comboBoxId}
15941592
listStateRef={listStateRef}
1595-
isLoading={isLoading}
1596-
allowsCustomValue={allowsCustomValue}
15971593
onChange={handleInputChange}
15981594
onFocus={handleInputFocus}
15991595
/>

0 commit comments

Comments
 (0)