feat(Dialog): border for popovers #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60f998c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for cube-uikit-docs failed.
|
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-210699c. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏗 Docs are successfully deployed!👀 Preview: https://684a91649ea7252cc4386c90--cube-uikit-docs.netlify.app |
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds consistent border styles to popover components (Menu, Select, ComboBox, Dialog), introduces <Divider/> support inside <Menu/>, and allows menu/combo items to have an optional description prop.
- Apply new border tokens on popovers across various components
- Integrate
<Divider/>intoMenurendering and adjust styled rules - Extend
Menu.ItemandComboBox.Itemto accept adescriptionprop with accompanying stories
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/pickers/Menu/styled.tsx | Updated menu/divider border token and spacing |
| src/components/pickers/Menu/MenuButton.tsx | Added optional description prop and layout tweaks for items |
| src/components/pickers/Menu/Menu.tsx | Render <Divider/> in menu, normalize keyed children |
| src/components/pickers/Menu/Menu.stories.tsx | Imported Divider and added stories for separators and descriptions |
| src/components/overlays/NewNotifications/NotificationsList/NotificationsList.tsx | Added qa attribute for testing |
| src/components/overlays/NewNotifications/Notifications.stories.tsx | Fixed import path for wait utility |
| src/components/overlays/NewNotifications/NotificationView/NotificationView.tsx | Added border radius to notification container |
| src/components/overlays/NewNotifications/Dialog/NotificationsDialogTrigger.tsx | Removed redundant border style |
| src/components/overlays/Dialog/Dialog.tsx | Enabled border for popover-type dialogs |
| src/components/fields/Select/Select.tsx | Enabled border on select popover |
| src/components/fields/ComboBox/ComboBox.tsx | Extended ComboBox.Item typing for description, added border |
| src/components/fields/ComboBox/ComboBox.stories.tsx | Added story showcasing combo items with descriptions |
| src/components/content/Divider.tsx | Implemented ARIA useSeparator and combined refs |
| .changeset/two-ladybugs-sparkle.md | Changelog: <Divider/> in <Menu/> support |
| .changeset/slimy-students-walk.md | Changelog: border for <Select/> and <ComboBox/> popovers |
| .changeset/silent-crabs-vanish.md | Changelog: border on dialog popovers |
| .changeset/loud-brooms-pull.md | Changelog: update disabled state for clear/neutral buttons |
| .changeset/itchy-lions-watch.md | Changelog: description prop in <ComboBox/> |
| .changeset/cool-geese-bow.md | Changelog: description prop in <Menu/> |
Comments suppressed due to low confidence (3)
src/components/fields/ComboBox/ComboBox.tsx:477
- Using
as unknown asto overrideComboBox.Itemtyping sacrifices its original generic signature and undermines type safety. Consider extending theItemcomponent's props via proper TypeScript generics or module augmentation to preserve its original type definitions while addingdescriptionsupport.
ComboBox.Item = Item as unknown as (props: {
src/components/pickers/Menu/Menu.tsx:229
- Casting
Menu.Itemthroughunknownhides its original props interface and may break generic usage. It would be better to extend the existingMenu.Itemtype via TypeScript interface merging or proper generic propagation to maintain type safety when adding thedescriptionprop.
Item: Item as unknown as (props: {
src/components/pickers/Menu/MenuButton.tsx:159
- The new
descriptionprop onMenu.Itemis a key user-facing feature but isn’t covered by any tests yet. Consider adding unit or integration tests to verify that descriptions render correctly and maintain proper accessibility roles.
{description ? (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.