-
Notifications
You must be signed in to change notification settings - Fork 6
fix(Menu): children as function * 2 #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fcefc3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for cube-uikit-docs failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Menu component to allow its children prop to also accept a function signature for dynamic collections, in addition to the standard ReactNode.
- Updates the typing and comment for the children prop in Menu.tsx.
- Updates the changeset for a patch release.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/pickers/Menu/Menu.tsx | Updated the children prop type and documentation to support a function signature returning a React element |
| .changeset/eight-dingos-invite.md | Changelog update reflecting the Menu type fix |
📦 NPM canary releaseDeployed canary version 0.0.0-canary-3c5f661. |
🏗 Docs are successfully deployed!👀 Preview: https://684af66dbc7208fc0625f0ec--cube-uikit-docs.netlify.app |
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
No description provided.