Skip to content

Conversation

@tenphi
Copy link
Member

@tenphi tenphi commented Jun 12, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2025

🦋 Changeset detected

Latest commit: fcefc3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 3:46pm

@netlify
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for cube-uikit-docs failed.

Name Link
🔨 Latest commit fcefc3b
🔍 Latest deploy log https://app.netlify.com/projects/cube-uikit-docs/deploys/684af631590ed400080e202a

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Menu component to allow its children prop to also accept a function signature for dynamic collections, in addition to the standard ReactNode.

  • Updates the typing and comment for the children prop in Menu.tsx.
  • Updates the changeset for a patch release.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/pickers/Menu/Menu.tsx Updated the children prop type and documentation to support a function signature returning a React element
.changeset/eight-dingos-invite.md Changelog update reflecting the Menu type fix

@github-actions
Copy link
Contributor

📦 NPM canary release

Deployed canary version 0.0.0-canary-3c5f661.

@github-actions
Copy link
Contributor

🏗 Docs are successfully deployed!

👀 Preview: https://684af66dbc7208fc0625f0ec--cube-uikit-docs.netlify.app

@github-actions
Copy link
Contributor

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

🏋️ Size limit report

Name Size Passed?
All 252.73 KB (0% 🟰) Yes 🎉
Tree shaking (just a Button) 21.72 KB (0% 🟰) Yes 🎉
Tree shaking (just an Icon) 11.4 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@tenphi tenphi merged commit 9fc76b5 into main Jun 12, 2025
13 of 17 checks passed
@tenphi tenphi deleted the fix-menu-types-2 branch June 12, 2025 15:50
@github-actions github-actions bot mentioned this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants