-
Notifications
You must be signed in to change notification settings - Fork 6
feat: condensed design #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f05f3b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-8262e57. |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
🧪 Storybook is successfully deployed!
|
| position: 'relative', | ||
| gridAreas: '"prefix input suffix"', | ||
| gridColumns: 'auto 1fr auto', | ||
| gridColumns: 'auto 1sf auto', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Invalid CSS Grid Unit Causes Layout Issues
The gridColumns property was incorrectly set to 'auto 1sf auto'. The value 1sf is an invalid CSS grid unit and should be 1fr (fractional unit) to properly distribute available space.
| </div> | ||
| </div> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Search Icon Missing When Not Loading
The FilterListBox no longer displays a search icon when not in a loading state. This is because the SearchIcon import was removed, and the icon's container is now only rendered when isLoading is true. Additionally, the LoadingIcon's rendering logic within this container is redundant, as it re-checks isLoading inside an already isLoading-conditional block.
No description provided.