fix(TextInput): input styling #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 864b160 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-e864021. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes minor issues with TextInput component styling by refactoring the CSS grid layout implementation and adjusting margin calculations for multiline inputs.
- Simplified grid area assignments by removing explicit grid area properties from Prefix and Suffix components
- Updated grid column definitions to use conditional styling based on prefix/suffix presence
- Modified margin calculations for multiline inputs to account for different size variants
- Reset vertical padding to 0 and adjusted multiline margin logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/components/fields/TextInput/TextInputBase.tsx | Refactored CSS grid layout, simplified component styling, and updated margin calculations for multiline inputs |
| .changeset/curly-trainers-walk.md | Added changeset entry documenting the input styling fixes |
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
🧪 Storybook is successfully deployed!
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
tenphi
had a problem deploying
to
Canary package in NPM
GitHub Actions
Error
tenphi
had a problem deploying
to
Canary package in NPM
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.