remove perf logging

Author: KSDaemon

packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.ts

@@ -23,7 +23,6 @@ import { CompilerInterface } from './PrepareCompiler';
 import { YamlCompiler } from './YamlCompiler';
 import { CubeDictionary } from './CubeDictionary';
 import { CompilerCache } from './CompilerCache';
-import { perfTracker } from './PerfTracker';
 
 const ctxFileStorage = new AsyncLocalStorage<FileContent>();
 
@@ -215,18 +214,13 @@ export class DataSchemaCompiler {
   protected async doCompile() {
     const files = await this.repository.dataSchemaFiles();
 
-    console.log(`Compiling ${files.length} files...`);
-    const compileTimer = perfTracker.start('doCompile', true);
-
     this.pythonContext = await this.loadPythonContext(files, 'globals.py');
     this.yamlCompiler.initFromPythonContext(this.pythonContext);
 
     const toCompile = this.filesToCompile?.length
       ? files.filter(f => this.filesToCompile.includes(f.fileName))
       : files;
 
-    const jinjaLoaderTimer = perfTracker.start('loadJinjaTemplates');
-
     const jinjaTemplatedFiles = toCompile.filter((file) => file.fileName.endsWith('.jinja') ||
       (file.fileName.endsWith('.yml') || file.fileName.endsWith('.yaml')) && file.content.match(JINJA_SYNTAX));
 
@@ -235,8 +229,6 @@ export class DataSchemaCompiler {
       this.loadJinjaTemplates(jinjaTemplatedFiles);
     }
 
-    jinjaLoaderTimer.end();
-
     const errorsReport = new ErrorReporter(null, [], this.errorReportOptions);
     this.errorsReporter = errorsReport;
 
@@ -254,8 +246,6 @@ export class DataSchemaCompiler {
     }
 
     const transpile = async (stage: CompileStage): Promise<FileContent[]> => {
-      const transpileTimer = perfTracker.start(`transpilation-stage-${stage}`);
-
       let cubeNames: string[] = [];
       let cubeSymbols: Record<string, Record<string, boolean>> = {};
       let transpilerNames: string[] = [];
@@ -322,8 +312,6 @@ export class DataSchemaCompiler {
         results = await Promise.all(toCompile.map(f => this.transpileFile(f, errorsReport, {})));
       }
 
-      transpileTimer.end();
-
       return results.filter(f => !!f) as FileContent[];
     };
 
@@ -420,8 +408,6 @@ export class DataSchemaCompiler {
     });
 
     const compilePhase = async (compilers: CompileCubeFilesCompilers, stage: 0 | 1 | 2 | 3) => {
-      const compilePhaseTimer = perfTracker.start(`compilation-phase-${stage}`);
-
       // clear the objects for the next phase
       cubes = [];
       exports = {};
@@ -430,9 +416,7 @@ export class DataSchemaCompiler {
       asyncModules = [];
       transpiledFiles = await transpile(stage);
 
-      const res = this.compileCubeFiles(cubes, contexts, compiledFiles, asyncModules, compilers, transpiledFiles, errorsReport);
-      compilePhaseTimer.end();
-      return res;
+      return this.compileCubeFiles(cubes, contexts, compiledFiles, asyncModules, compilers, transpiledFiles, errorsReport);
     };
 
     return compilePhase({ cubeCompilers: this.cubeNameCompilers }, 0)
@@ -468,12 +452,6 @@ export class DataSchemaCompiler {
         } else if (transpilationWorkerThreads && this.workerPool) {
           this.workerPool.terminate();
         }
-
-        // End overall compilation timing and print performance report
-        compileTimer.end();
-        setImmediate(() => {
-          perfTracker.printReport();
-        });
       });
   }
 
@@ -504,7 +482,6 @@ export class DataSchemaCompiler {
 
     const jinjaEngine = this.yamlCompiler.getJinjaEngine();
 
-    // XXX: Make this as bulk operation in the native side
     files.forEach((file) => {
       jinjaEngine.loadTemplate(file.fileName, file.content);
     });
@@ -538,8 +515,6 @@ export class DataSchemaCompiler {
     errorsReport: ErrorReporter,
     { cubeNames, cubeSymbols, contextSymbols, transpilerNames, compilerId, stage }: TranspileOptions
   ): Promise<(FileContent | undefined)[]> {
-    const compileJsFileTimer = perfTracker.start('transpileJsFilesBulk (native)');
-
     // for bulk processing this data may be optimized even more by passing transpilerNames, compilerId only once for a bulk
     // but this requires more complex logic to be implemented in the native side.
     // And comparing to the file content sizes, a few bytes of JSON data is not a big deal here
@@ -559,8 +534,6 @@ export class DataSchemaCompiler {
     }));
     const res = await transpileJs(reqDataArr);
 
-    compileJsFileTimer.end();
-
     return files.map((file, index) => {
       errorsReport.inFile(file);
       if (!res[index]) { // This should not happen in theory but just to be safe
@@ -582,8 +555,6 @@ export class DataSchemaCompiler {
   ): Promise<(FileContent | undefined)> {
     try {
       if (getEnv('transpilationNative')) {
-        const compileJsFileTimer = perfTracker.start('transpileJsFile (native)');
-
         const reqData = {
           fileName: file.fileName,
           fileContent: file.content,
@@ -605,12 +576,8 @@ export class DataSchemaCompiler {
         errorsReport.addWarnings(res[0].warnings as unknown as SyntaxErrorInterface[]);
         errorsReport.exitFile();
 
-        compileJsFileTimer.end();
-
         return { ...file, content: res[0].code };
       } else if (getEnv('transpilationWorkerThreads')) {
-        const compileJsFileTimer = perfTracker.start('transpileJsFile (threads)');
-
         const data = {
           fileName: file.fileName,
           content: file.content,
@@ -623,12 +590,8 @@ export class DataSchemaCompiler {
         errorsReport.addErrors(res.errors);
         errorsReport.addWarnings(res.warnings);
 
-        compileJsFileTimer.end();
-
         return { ...file, content: res.content };
       } else {
-        const compileJsFileTimer = perfTracker.start('transpileJsFile (inplace)');
-
         const ast = parse(
           file.content,
           {
@@ -646,8 +609,6 @@ export class DataSchemaCompiler {
 
         const content = babelGenerator(ast, {}, file.content).code;
 
-        compileJsFileTimer.end();
-
         return { ...file, content };
       }
     } catch (e: any) {
@@ -672,8 +633,6 @@ export class DataSchemaCompiler {
     { cubeNames, cubeSymbols, compilerId }: TranspileOptions
   ): Promise<(FileContent | undefined)> {
     if (getEnv('transpilationNative')) {
-      const transpileYamlFileTimer = perfTracker.start('transpileYamlFile (native)');
-
       const reqData = {
         fileName: file.fileName,
         fileContent: file.content,
@@ -690,12 +649,8 @@ export class DataSchemaCompiler {
       file.content = res[0].code;
       file.convertedToJs = true;
 
-      transpileYamlFileTimer.end();
-
       return { ...file, content: res[0].code };
     } else if (getEnv('transpilationWorkerThreads')) {
-      const transpileYamlFileTimer = perfTracker.start('transpileYamlFile (threads)');
-
       const data = {
         fileName: file.fileName,
         content: file.content,
@@ -711,21 +666,15 @@ export class DataSchemaCompiler {
       file.content = res.content;
       file.convertedToJs = true;
 
-      transpileYamlFileTimer.end();
-
       return { ...file, content: res.content };
     } else {
-      const transpileYamlFileTimer = perfTracker.start('transpileYamlFile (inplace)');
-
       const transpiledFile = this.yamlCompiler.transpileYamlFile(file, errorsReport);
 
       if (transpiledFile) {
         file.content = transpiledFile.content;
         file.convertedToJs = true;
       }
 
-      transpileYamlFileTimer.end();
-
       return transpiledFile;
     }
   }
@@ -735,8 +684,6 @@ export class DataSchemaCompiler {
     errorsReport: ErrorReporter,
     options: TranspileOptions
   ): Promise<(FileContent | undefined)> {
-    const transpileJinjaFileTimer = perfTracker.start('transpileJinjaFile (common)');
-
     const renderedFile = await this.yamlCompiler.renderTemplate(
       file,
       this.standalone ? {} : this.cloneCompileContextWithGetterAlias(this.compileContext),
@@ -749,8 +696,6 @@ export class DataSchemaCompiler {
     // avoiding costly YAML/Python parsing again.
     file.content = renderedFile.content;
 
-    transpileJinjaFileTimer.end();
-
     return this.transpileYamlFile(file, errorsReport, options);
   }
 
@@ -807,26 +752,18 @@ export class DataSchemaCompiler {
     compiledFiles[file.fileName] = true;
 
     if (file.convertedToJs) {
-      const compileJsFileTimer = perfTracker.start('compileJsFile (convertedToJs)');
       this.compileJsFile(file, errorsReport);
-      compileJsFileTimer.end();
     } else if (file.fileName.endsWith('.js')) {
-      const compileJsFileTimer = perfTracker.start('compileJsFile');
       this.compileJsFile(file, errorsReport, { doSyntaxCheck });
-      compileJsFileTimer.end();
     } else if (file.fileName.endsWith('.yml.jinja') || file.fileName.endsWith('.yaml.jinja') ||
       (file.fileName.endsWith('.yml') || file.fileName.endsWith('.yaml')) &&
       file.content.match(JINJA_SYNTAX)
     ) {
-      const compileJinjaFileTimer = perfTracker.start('compileJinjaFile (actually js)');
       // original jinja/yaml file was already transpiled into js
       this.compileJsFile(file, errorsReport);
-      compileJinjaFileTimer.end();
     } else if (file.fileName.endsWith('.yml') || file.fileName.endsWith('.yaml')) {
-      const compileYamlFileTimer = perfTracker.start('compileYamlFile (actually js)');
       // original yaml file was already transpiled into js
       this.compileJsFile(file, errorsReport);
-      compileYamlFileTimer.end();
     }
   }
 

packages/cubejs-schema-compiler/src/compiler/YamlCompiler.ts

@@ -19,7 +19,6 @@ import { nonStringFields } from './CubeValidator';
 import { ErrorReporter } from './ErrorReporter';
 import { camelizeCube } from './utils';
 import { CompileContext } from './DataSchemaCompiler';
-import { perfTracker } from './PerfTracker';
 
 type EscapeStateStack = {
   inFormattedStr?: boolean;