move guard to the filter_params proxy

Author: KSDaemon

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

@@ -2241,13 +2241,6 @@ export class BaseQuery {
       }
     }
 
-    // This is a special recursion guard that might happen sometimes, like
-    // during alias members collection which invokes sql evaluation of all members
-    // when FILTER_PARAMS is proxied for SQL evaluation.
-    if (parentMember === memberPath && this.safeEvaluateSymbolContext().aliasGathering) {
-      return '';
-    }
-
     this.safeEvaluateSymbolContext().currentMember = memberPath;
     try {
       if (type === 'measure') {
@@ -3895,10 +3888,11 @@ export class BaseQuery {
                 // allBackAliasMembersExceptSegments() -> collectFrom() -> traverseSymbol() -> evaluateSymbolSql() ->
                 // autoPrefixAndEvaluateSql() -> evaluateSql() -> filterProxyFromAllFilters->Proxy->toString()
                 // and so on...
-                // For this case there is a recursion guard added to this.evaluateSymbolSql()
+                // For this case aliasGathering flag is added to the context in first iteration and
+                // is checked below to prevent looping.
                 const aliases = allFilters ?
                   allFilters
-                    .map(v => (v.query ? v.query.allBackAliasMembersExceptSegments() : {}))
+                    .map(v => (v.query && !v.query.safeEvaluateSymbolContext().aliasGathering ? v.query.allBackAliasMembersExceptSegments() : {}))
                     .reduce((a, b) => ({ ...a, ...b }), {})
                   : {};
                 // Filtering aliases that somehow relate to this group member