Skip to content

Commit 0819075

Browse files
authored
fix(snowflake-driver): Bind variable ? not set for partitioned pre-aggregations (#6594)
1 parent b4ecea6 commit 0819075

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {
430430
if (!options.query) {
431431
throw new Error('Unload query is missed.');
432432
} else {
433-
const types = await this.queryColumnTypes(options.query.sql);
433+
const types = await this.queryColumnTypes(options.query.sql, options.query.params);
434434
const connection = await this.getConnection();
435435
const { bucketType, bucketName } =
436436
<SnowflakeDriverExportBucket> this.config.exportBucket;
@@ -441,7 +441,7 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {
441441
const result = await this.execute<UnloadResponse[]>(
442442
connection,
443443
unloadSql,
444-
[],
444+
options.query.params,
445445
false,
446446
);
447447
if (!result) {
@@ -454,11 +454,11 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {
454454
/**
455455
* Returns an array of queried fields meta info.
456456
*/
457-
public async queryColumnTypes(sql: string): Promise<TableStructure> {
457+
public async queryColumnTypes(sql: string, params?: unknown[]): Promise<TableStructure> {
458458
const connection = await this.getConnection();
459459
return new Promise((resolve, reject) => connection.execute({
460460
sqlText: `${sql} LIMIT 0`,
461-
binds: [],
461+
binds: <string[] | undefined>params,
462462
fetchAsString: ['Number'],
463463
complete: (err, stmt) => {
464464
if (err) {

packages/cubejs-testing-drivers/fixtures/snowflake.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,12 @@
1414
"CUBEJS_DB_SNOWFLAKE_ACCOUNT": "qna80818.us-east-1",
1515
"CUBEJS_DB_SNOWFLAKE_REGION": "us-east-1",
1616
"CUBEJS_DB_SNOWFLAKE_WAREHOUSE": "COMPUTE_WH",
17-
"CUBEJS_DB_SNOWFLAKE_ROLE": "PUBLIC"
17+
"CUBEJS_DB_SNOWFLAKE_ROLE": "PUBLIC",
18+
"CUBEJS_DB_EXPORT_BUCKET": "athena-drivers-tests-preaggs",
19+
"CUBEJS_DB_EXPORT_BUCKET_TYPE": "s3",
20+
"CUBEJS_DB_EXPORT_BUCKET_AWS_KEY": "${DRIVERS_TESTS_ATHENA_CUBEJS_AWS_KEY}",
21+
"CUBEJS_DB_EXPORT_BUCKET_AWS_SECRET": "${DRIVERS_TESTS_ATHENA_CUBEJS_AWS_SECRET}",
22+
"CUBEJS_DB_EXPORT_BUCKET_AWS_REGION": "us-east-1"
1823
},
1924
"ports" : ["4000"]
2025
},

0 commit comments

Comments
 (0)