comments with types

KSDaemon · KSDaemon · commit 084d105af19d · 2025-09-15T14:30:34.000+03:00
diff --git a/packages/cubejs-api-gateway/src/gateway.ts b/packages/cubejs-api-gateway/src/gateway.ts
@@ -177,7 +177,13 @@ class ApiGateway {
 
   public constructor(
     protected readonly apiSecret: string,
+    /**
+     * It actually returns a Promise<CompilerApi>
+     */
     protected readonly compilerApi: (ctx: RequestContext) => Promise<any>,
+    /**
+     * It actually returns a Promise<OrchestratorApi>
+     */
     protected readonly adapterApi: (ctx: RequestContext) => Promise<any>,
     protected readonly logger: any,
     protected readonly options: ApiGatewayOptions,
diff --git a/packages/cubejs-server-core/src/core/CompilerApi.js b/packages/cubejs-server-core/src/core/CompilerApi.js
@@ -504,7 +504,7 @@ export class CompilerApi {
 
   /**
    *
-   * @param {unknown} filter
+   * @param {unknown|undefined} filter
    * @returns {Promise<Array<PreAggregationInfo>>}
    */
   async preAggregations(filter) {

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ export class CompilerApi {`
`504`	`504`
`505`	`505`	`/**`
`506`	`506`	`*`
`507`		`- * @param {unknown} filter`
	`507`	`+ * @param {unknown\|undefined} filter`
`508`	`508`	`* @returns {Promise<Array<PreAggregationInfo>>}`
`509`	`509`	`*/`
`510`	`510`	`async preAggregations(filter) {`