Skip to content

Commit 0aee4fc

Browse files
feat(duckdb-driver): remove unnecessary installing and loading HttpFS extension (#8375)
* feat(duckdb-driver): Upgrade to DuckDB 1.0.0 * feat(duckdb-driver): remove installing and loading httpfs extension httpfs installed by default and its auto loadable extension --------- Co-authored-by: Konstantin Burkalev <[email protected]>
1 parent 47e7897 commit 0aee4fc

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

packages/cubejs-duckdb-driver/src/DuckDBDriver.ts

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -81,32 +81,6 @@ export class DuckDBDriver extends BaseDriver implements DriverInterface {
8181
const defaultConnection = db.connect();
8282
const execAsync: (sql: string, ...params: any[]) => Promise<void> = promisify(defaultConnection.exec).bind(defaultConnection) as any;
8383

84-
try {
85-
await execAsync('INSTALL httpfs');
86-
} catch (e) {
87-
if (this.logger) {
88-
console.error('DuckDB - error on httpfs installation', {
89-
e
90-
});
91-
}
92-
93-
// DuckDB will lose connection_ref on connection on error, this will lead to broken connection object
94-
throw e;
95-
}
96-
97-
try {
98-
await execAsync('LOAD httpfs');
99-
} catch (e) {
100-
if (this.logger) {
101-
console.error('DuckDB - error on loading httpfs', {
102-
e
103-
});
104-
}
105-
106-
// DuckDB will lose connection_ref on connection on error, this will lead to broken connection object
107-
throw e;
108-
}
109-
11084
const configuration = [
11185
{
11286
key: 's3_region',

0 commit comments

Comments
 (0)