Skip to content

Commit 0d04034

Browse files
committed
chore(ci): Enable unit and integration tests for node.js v24
1 parent 212088b commit 0d04034

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/push.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ jobs:
8282
strategy:
8383
matrix:
8484
# Current docker version + next LTS
85-
# TODO: Add 24 after it's been released
86-
node-version: [22.x]
85+
node-version: [22.x, 24.x]
8786
# Don't forget to update build-native-release
8887
python-version: [3.11]
8988
transpile-worker-threads: [false, true]
@@ -419,7 +418,7 @@ jobs:
419418

420419
strategy:
421420
matrix:
422-
node-version: [22.x]
421+
node-version: [22.x, 24.x]
423422
# Vertica tests are disabled because around 20.08.2025 someone
424423
# totally removed all vertica-ce docker repository from dockerhub.
425424
# @see https://github.com/vertica/vertica-containers/issues/64
@@ -523,13 +522,16 @@ jobs:
523522
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_USER: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_SNOWFLAKE_USER }}
524523
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_PASS: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_SNOWFLAKE_PASS }}
525524
- name: Fix lcov paths
525+
if: (matrix.node-version == '24.x')
526526
run: |
527527
./.github/actions/codecov-fix.sh
528528
- name: Combine all fixed LCOV files
529+
if: (matrix.node-version == '24.x')
529530
run: |
530531
echo "" > ./combined-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}.lcov
531532
find ./packages -type f -name lcov.fixed.info -exec cat {} + >> ./combined-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}.lcov || true
532533
- name: Upload coverage artifact
534+
if: (matrix.node-version == '24.x')
533535
uses: actions/upload-artifact@v4
534536
with:
535537
name: coverage-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}

0 commit comments

Comments
 (0)