feat(schema-compiler)!: Set preAggregation.allowNonStrictDateRangeMatch = true by default

Author: KSDaemon

packages/cubejs-backend-shared/src/env.ts

@@ -226,6 +226,9 @@ const variables: Record<string, (...args: any) => any> = {
   transpilationWorkerThreads: () => get('CUBEJS_TRANSPILATION_WORKER_THREADS')
     .default('false')
     .asBoolStrict(),
+  allowNonStrictDateRangeMatching: () => get('CUBEJS_PRE_AGGREGATIONS_ALLOW_NON_STRICT_DATE_RANGE_MATCH')
+    .default('true')
+    .asBoolStrict(),
   transpilationWorkerThreadsCount: () => get('CUBEJS_TRANSPILATION_WORKER_THREADS_COUNT')
     .default('0')
     .asInt(),

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

@@ -246,6 +246,12 @@ export class CubeSymbols {
           preAggregation.type = 'rollup';
         }
 
+        if (preAggregation.allowNonStrictDateRangeMatch === undefined &&
+          ['originalSql', 'rollupJoin', 'rollup'].includes(preAggregation.type) &&
+          (preAggregation.timeDimension || preAggregation.timeDimensions)) {
+          preAggregation.allowNonStrictDateRangeMatch = getEnv('allowNonStrictDateRangeMatching');
+        }
+
         if (preAggregation.scheduledRefresh === undefined && preAggregation.type !== 'rollupJoin' && preAggregation.type !== 'rollupLambda') {
           preAggregation.scheduledRefresh = getEnv('scheduledRefreshDefault');
         }

packages/cubejs-schema-compiler/test/unit/schema.test.ts

@@ -69,6 +69,7 @@ describe('Schema Testing', () => {
         refreshRangeEnd: {
           sql: expect.any(Function),
         },
+        allowNonStrictDateRangeMatch: true,
       },
       countCreatedAt: {
         external: true,
@@ -102,6 +103,7 @@ describe('Schema Testing', () => {
         refreshRangeEnd: {
           sql: expect.any(Function),
         },
+        allowNonStrictDateRangeMatch: true,
       }
     });
   });
@@ -128,6 +130,7 @@ describe('Schema Testing', () => {
         refreshRangeEnd: {
           sql: expect.any(Function),
         },
+        allowNonStrictDateRangeMatch: true,
       },
       countCreatedAt: {
         // because preview
@@ -162,6 +165,7 @@ describe('Schema Testing', () => {
         refreshRangeEnd: {
           sql: expect.any(Function),
         },
+        allowNonStrictDateRangeMatch: true,
       }
     });
   });