chore: Use name instead of cube in cubes parameter (#6522)

* chore: Use name instead of cube in cubes parameter

* Remove redundant logs

* remove more redundant logs

* clean up error message log

* name -> join_path

* Fix js test

* make joinPath expression not string

Author: keydunov

packages/cubejs-schema-compiler/src/compiler/CubeEvaluator.js

@@ -193,7 +193,7 @@ export class CubeEvaluator extends CubeSymbols {
    */
   membersFromCubes(cubes, type, errorReporter) {
     return R.unnest(cubes.map(cubeInclude => {
-      const fullPath = this.evaluateReferences(null, cubeInclude.cube, { collectJoinHints: true });
+      const fullPath = this.evaluateReferences(null, cubeInclude.joinPath, { collectJoinHints: true });
       const split = fullPath.split('.');
       const cubeReference = split[split.length - 1];
       const cubeName = cubeInclude.alias || cubeReference;

packages/cubejs-schema-compiler/src/compiler/CubeValidator.js

@@ -539,7 +539,7 @@ const viewSchema = inherit(baseSchema, {
   excludes: Joi.func(),
   cubes: Joi.array().items(
     Joi.object().keys({
-      cube: Joi.func().required(),
+      joinPath: Joi.func().required(),
       prefix: Joi.boolean(),
       alias: Joi.string(),
       includes: Joi.alternatives([

packages/cubejs-schema-compiler/src/compiler/transpilers/CubePropContextTranspiler.ts

@@ -17,7 +17,7 @@ export const transpiledFieldsPatterns: Array<RegExp> = [
   /^contextMembers$/,
   /^includes$/,
   /^excludes$/,
-  /^cubes\.[0-9]+\.cube$/,
+  /^cubes\.[0-9]+\.joinPath$/,
 ];
 
 export const transpiledFields: Set<String> = new Set<String>();

packages/cubejs-schema-compiler/src/compiler/utils.ts

@@ -40,6 +40,7 @@ export function camelizeCube(cube: any): unknown {
   camelizeObjectPart(cube.measures, false);
   camelizeObjectPart(cube.dimensions, false);
   camelizeObjectPart(cube.preAggregations, false);
+  camelizeObjectPart(cube.cubes, false);
 
   return cube;
 }

packages/cubejs-schema-compiler/test/integration/postgres/yaml-compiler.test.ts

@@ -348,14 +348,14 @@ views:
   - name: orders_view
 
     cubes:
-      - cube: orders
+      - join_path: orders
         prefix: true
         includes:
           - count
           - name: time
             alias: date
 
-      - cube: orders.customers
+      - join_path: orders.customers
         alias: aliased_customers
         prefix: true
         includes:

packages/cubejs-testing/birdbox-fixtures/driver-test-data/ECommerce.js

@@ -120,7 +120,7 @@ cube(`ECommerce`, {
 
 view(`ECommerceView`, {
   cubes: [{
-    cube: ECommerce,
+    joinPath: ECommerce,
     includes: `*`,
     excludes: [`orderDate`]
   }]