Skip to content

Commit 0dbc499

Browse files
authored
chore(cubestore): Remove dependency on feature(cursor_remaining) in cubehll (#8964)
This got removed in more recent versions of Rust.
1 parent b75a37a commit 0dbc499

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

rust/cubestore/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ exclude this from your PR!)
153153
```
154154

155155
[patch.'https://github.com/cube-js/arrow-rs']
156-
arquet = { path = "../../../arrow-rs/parquet" }
156+
parquet = { path = "../../../arrow-rs/parquet" }
157157
arrow = { path = "../../../arrow-rs/arrow" }
158158

159159
[patch.'https://github.com/cube-js/arrow-datafusion']

rust/cubestore/cubehll/src/instance.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ impl HllInstance {
201201
let mut values = Vec::with_capacity(num_hashes);
202202
let mut data = Cursor::new(data);
203203
let maxval = (1 << reg_width) as u32 - 1;
204-
while !data.is_empty() {
204+
while data.position() < data.get_ref().len() as u64 {
205205
let hash = data.read_u64::<BigEndian>().unwrap();
206206
let ind = hash & mask;
207207
let val = hash >> log_num_buckets;

rust/cubestore/cubehll/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![feature(cursor_remaining)]
21
/*
32
* Licensed under the Apache License, Version 2.0 (the "License");
43
* you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)