PR comments

Author: paco-valdez

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

@@ -893,7 +893,7 @@ export class CubeSymbols {
           name
         );
       // eslint-disable-next-line no-underscore-dangle
-      if (resolvedSymbol && resolvedSymbol._objectWithResolvedProperties) {
+      if (resolvedSymbol?._objectWithResolvedProperties) {
         return resolvedSymbol;
       }
       return cubeEvaluator.pathFromArray(fullPath(cubeEvaluator.joinHints(), [referencedCube, name]));
@@ -1003,7 +1003,7 @@ export class CubeSymbols {
           cubeName,
           name
         );
-        if (resolvedSymbol && resolvedSymbol._objectWithResolvedProperties) {
+        if (resolvedSymbol?._objectWithResolvedProperties) {
           return resolvedSymbol;
         }
         return '';

packages/cubejs-schema-compiler/src/compiler/CubeToMetaTransformer.js

@@ -226,8 +226,7 @@ export class CubeToMetaTransformer {
           const filteredDrillMembers = drillMembersArray.filter(member => availableMembers.has(member));
 
           // Update the drillMembersArray with filtered results
-          drillMembersArray.length = 0;
-          drillMembersArray.push(...filteredDrillMembers);
+          drillMembersArray.splice(0, drillMembersArray.length, ...filteredDrillMembers);
         }
       }
     }