Skip to content

Commit 108eea6

Browse files
committed
refactor(cubesql): Remove unused plan argument from CubeScanWrapperNode::generate_column_expr
1 parent dd00d09 commit 108eea6

File tree

1 file changed

+0
-8
lines changed
  • rust/cubesql/cubesql/src/compile/engine/df

1 file changed

+0
-8
lines changed

rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,7 +1172,6 @@ impl CubeScanWrapperNode {
11721172
})?
11731173
.clone();
11741174
let (projection, sql) = Self::generate_column_expr(
1175-
plan.clone(),
11761175
schema.clone(),
11771176
projection_expr.clone(),
11781177
sql,
@@ -1186,7 +1185,6 @@ impl CubeScanWrapperNode {
11861185
.await?;
11871186
let flat_group_expr = extract_exprlist_from_groupping_set(&group_expr);
11881187
let (group_by, sql) = Self::generate_column_expr(
1189-
plan.clone(),
11901188
schema.clone(),
11911189
flat_group_expr.clone(),
11921190
sql,
@@ -1200,7 +1198,6 @@ impl CubeScanWrapperNode {
12001198
.await?;
12011199
let group_descs = extract_group_type_from_groupping_set(&group_expr)?;
12021200
let (aggregate, sql) = Self::generate_column_expr(
1203-
plan.clone(),
12041201
schema.clone(),
12051202
aggr_expr.clone(),
12061203
sql,
@@ -1214,7 +1211,6 @@ impl CubeScanWrapperNode {
12141211
.await?;
12151212

12161213
let (filter, sql) = Self::generate_column_expr(
1217-
plan.clone(),
12181214
schema.clone(),
12191215
filter_expr.clone(),
12201216
sql,
@@ -1228,7 +1224,6 @@ impl CubeScanWrapperNode {
12281224
.await?;
12291225

12301226
let (window, sql) = Self::generate_column_expr(
1231-
plan.clone(),
12321227
schema.clone(),
12331228
window_expr.clone(),
12341229
sql,
@@ -1242,7 +1237,6 @@ impl CubeScanWrapperNode {
12421237
.await?;
12431238

12441239
let (order, mut sql) = Self::generate_column_expr(
1245-
plan.clone(),
12461240
schema.clone(),
12471241
order_expr.clone(),
12481242
sql,
@@ -1270,7 +1264,6 @@ impl CubeScanWrapperNode {
12701264
{
12711265
// Need to call generate_column_expr to apply column_remapping
12721266
let (join_condition, new_sql) = Self::generate_column_expr(
1273-
plan.clone(),
12741267
schema.clone(),
12751268
[condition.clone()],
12761269
sql,
@@ -1582,7 +1575,6 @@ impl CubeScanWrapperNode {
15821575
}
15831576

15841577
async fn generate_column_expr(
1585-
_plan: Arc<Self>,
15861578
schema: DFSchemaRef,
15871579
exprs: impl IntoIterator<Item = Expr>,
15881580
mut sql: SqlQuery,

0 commit comments

Comments
 (0)