Skip to content

Commit 10b40e7

Browse files
committed
Add drillMembers and drillMembersGrouped to inhereted properties by views
1 parent 456e1ba commit 10b40e7

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -809,6 +809,8 @@ export class CubeSymbols {
809809
...(resolvedMember.multiStage && { multiStage: resolvedMember.multiStage }),
810810
...(resolvedMember.timeShift && { timeShift: resolvedMember.timeShift }),
811811
...(resolvedMember.orderBy && { orderBy: resolvedMember.orderBy }),
812+
...(resolvedMember.drillMembers && { drillMembers: resolvedMember.drillMembers }),
813+
...(resolvedMember.drillMembersGrouped && { drillMembersGrouped: resolvedMember.drillMembersGrouped }),
812814
};
813815
} else if (type === 'dimensions') {
814816
memberDefinition = {

packages/cubejs-schema-compiler/test/integration/postgres/cube-views.test.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ cube(\`Orders\`, {
4747
measures: {
4848
count: {
4949
type: \`count\`,
50-
//drillMembers: [id, createdAt]
50+
drillMembers: [id, createdAt]
5151
},
5252
5353
runningTotal: {
@@ -429,4 +429,15 @@ view(\`OrdersView3\`, {
429429
orders_view3__count: '2',
430430
orders_view3__product_categories__name: 'Groceries',
431431
}]));
432+
433+
it('check drillMembers are inherited in views', async () => {
434+
await compiler.compile();
435+
const cube = metaTransformer.cubes.find(c => c.config.name === 'OrdersView');
436+
const countMeasure = cube.config.measures.find((m) => m.name === 'OrdersView.count');
437+
expect(countMeasure.drillMembers).toEqual(['OrdersView.id', 'OrdersView.createdAt']);
438+
expect(countMeasure.drillMembersGrouped).toEqual({
439+
measures: [],
440+
dimensions: ['OrdersView.id', 'OrdersView.createdAt']
441+
});
442+
});
432443
});

0 commit comments

Comments
 (0)