Skip to content

Commit 129555a

Browse files
authored
Add missing typings (#7412)
1 parent baabd41 commit 129555a

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

packages/cubejs-client-core/index.d.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,12 @@ declare module '@cubejs-client/core' {
905905
name: string;
906906
title: string;
907907
shortTitle: string;
908+
description?: string;
909+
/**
910+
* @deprecated use `public` instead
911+
*/
908912
isVisible?: boolean;
913+
public?: boolean;
909914
meta?: any;
910915
};
911916

@@ -914,7 +919,12 @@ declare module '@cubejs-client/core' {
914919
name: string;
915920
title: string;
916921
shortTitle: string;
922+
description?: string;
923+
/**
924+
* @deprecated use `public` instead
925+
*/
917926
isVisible?: boolean;
927+
public?: boolean;
918928
meta?: any;
919929
};
920930

@@ -931,6 +941,7 @@ declare module '@cubejs-client/core' {
931941
};
932942

933943
export type TCubeDimension = BaseCubeMember & {
944+
primaryKey?: boolean;
934945
suggestFilterValues: boolean;
935946
};
936947

@@ -968,10 +979,17 @@ declare module '@cubejs-client/core' {
968979
export type Cube = {
969980
name: string;
970981
title: string;
982+
description?: string;
971983
measures: TCubeMeasure[];
972984
dimensions: TCubeDimension[];
973985
segments: TCubeSegment[];
974986
connectedComponent?: number;
987+
type?: 'view' | 'cube';
988+
/**
989+
* @deprecated use `public` instead
990+
*/
991+
isVisible?: boolean;
992+
public?: boolean;
975993
};
976994

977995

packages/cubejs-client-react/src/QueryRenderer.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import CubeContext from './CubeContext';
66

77
export default class QueryRenderer extends React.Component {
88
static contextType = CubeContext;
9-
9+
1010
static defaultProps = {
1111
cubejsApi: null,
1212
query: null,
@@ -16,8 +16,8 @@ export default class QueryRenderer extends React.Component {
1616
updateOnlyOnStateChange: false,
1717
resetResultSetOnChange: true
1818
};
19-
20-
// @deprected use `isQueryPresent` from `@cubejs-client/core`
19+
20+
// @deprecated use `isQueryPresent` from `@cubejs-client/core`
2121
static isQueryPresent(query) {
2222
return isQueryPresent(query);
2323
}

0 commit comments

Comments
 (0)